Skip to content

Commit b6c0276

Browse files
fix: v2 non-field api support (#5178)
* fix: support non-field api in ssr * chore: tests * fix: additional coverage, redundant api decorator error * chore: add throw TODO * fix: added tests
1 parent 476bb41 commit b6c0276

File tree

33 files changed

+177
-24
lines changed

33 files changed

+177
-24
lines changed

packages/@lwc/engine-server/src/__tests__/fixtures/api/decorated-getter/error.txt

Whitespace-only changes.
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<x-parent>
2+
<template shadowrootmode="open">
3+
<x-child>
4+
<template shadowrootmode="open">
5+
const setter getter api value
6+
</template>
7+
</x-child>
8+
<x-child>
9+
<template shadowrootmode="open">
10+
setter getter api value
11+
</template>
12+
</x-child>
13+
</template>
14+
</x-parent>
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
export const tagName = 'x-parent';
2+
export { default } from 'x/parent';
3+
export * from 'x/parent';
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<template>
2+
{setterGetterApi}
3+
</template>
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import { LightningElement, api } from 'lwc';
2+
3+
export default class Child extends LightningElement {
4+
set setterGetterApi(value) {
5+
this._someApi = value;
6+
}
7+
8+
@api
9+
get setterGetterApi() {
10+
return this._someApi;
11+
}
12+
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
<template>
2+
<x-child setter-getter-api="const setter getter api value"></x-child>
3+
<x-child setter-getter-api={setterGetterApiValue}></x-child>
4+
</template>
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { LightningElement } from 'lwc';
2+
3+
export default class Parent extends LightningElement {
4+
setterGetterApiValue = 'setter getter api value';
5+
}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
LWC1112: @api get setterGetterApi and @api set setterGetterApi detected in class declaration. Only one of the two needs to be decorated with @api.

packages/@lwc/engine-server/src/__tests__/fixtures/api/decorated-setter-getter/expected.html

Whitespace-only changes.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
export const tagName = 'x-parent';
2+
export { default } from 'x/parent';
3+
export * from 'x/parent';

0 commit comments

Comments
 (0)