Skip to content

Commit

Permalink
chore: facilitate manual type checking @W-15023469 (#3992)
Browse files Browse the repository at this point in the history
* chore(scripts): add typecheck script

* chore(types): remove unnecessary type def

no longer needed, as we now use ES2021 types

* ci: add step to run type checks

* chore(tsconfig): set noEmit flag to make tsc easier to use

Doesn't impact rollup config.

* Revert "ci: add step to run type checks"

This reverts commit 9c81472.

* Revert "chore(scripts): add typecheck script"

This reverts commit f441ba3.
  • Loading branch information
wjhsf authored Feb 13, 2024
1 parent 971098d commit d9588c7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 65 deletions.
64 changes: 0 additions & 64 deletions packages/@lwc/engine-core/src/typings/weakref.d.ts

This file was deleted.

6 changes: 5 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@

// @rollup/plugin-typescript is actually responsible for writing dist files. Using "." as the declarationDir
// ensures that .d.ts files are co-located with JS files, e.g. `dist/index.js` and `dist/index.d.ts`.
"declarationDir": "."
"declarationDir": ".",

// @rollup/plugin-typescript ignores this setting (it always emits); we can set it here to
// facilitate type checking without running the full build
"noEmit": true
},

"exclude": [
Expand Down

0 comments on commit d9588c7

Please sign in to comment.