fix(signals): avoid throwing when in check throws#5105
Merged
nolanlawson merged 5 commits intomasterfrom Jan 8, 2025
Merged
Conversation
wjhsf
approved these changes
Jan 8, 2025
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
nolanlawson
added a commit
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
nolanlawson
added a commit
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixes #5104
Avoids throwing an error when the
inoperator throws an error on an arbitrary object.This should not cause any breaking changes, because we are trying to detect if an object "looks" like a signal, and if checking
'value' in objectthrows, then we can conclusively say it's not a signal.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?