Skip to content

chore(eslint): disallow fdescribe/fit #5107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nolanlawson merged 1 commit into from
Jan 8, 2025
Merged

chore(eslint): disallow fdescribe/fit #5107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,19 @@ export default tseslint.config(
'vitest/valid-expect-in-promise': 'error',
'vitest/no-conditional-tests': 'error',
'vitest/no-done-callback': 'error',
// Note that vitest's "no focused tests" rules do not cover `fit`/`fdescribe`
// https://github.com/salesforce/lwc/issues/5106
'no-restricted-globals': [
'error',
{
name: 'fdescribe',
message: 'Do not commit focused tests. Use `describe` instead.',
},
{
name: 'fit',
message: 'Do not commit focused tests. Use `it` instead.',
},
],
},
},
{
Expand Down