Skip to content

chore: release v8.12.4#5112

Merged
salesforce-nucleus[bot] merged 10 commits intoreleasefrom
nolan/release-20250108-2
Jan 8, 2025
Merged

chore: release v8.12.4#5112
salesforce-nucleus[bot] merged 10 commits intoreleasefrom
nolan/release-20250108-2

Conversation

@nolanlawson
Copy link
Contributor

@nolanlawson nolanlawson commented Jan 8, 2025

Details

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

wjhsf and others added 10 commits January 6, 2025 17:52
@wjhsf
chore: 2025 (#5100)
891f3fb 
* chore: 2025

* chore: 2025
@jhefferman-sfdc
Fix aria null values (#5097)
b2468c9 
* fix: align aria null behavior between setting methods

* fix: setAttribute string case

* fix: revert missing stringify

* fix: revert deletion

* fix: revert setAttribute 'null' behavior change
@nolanlawson
perf(ssr): remove filterProperties (#5101)
0b12680
@nolanlawson
docs: add ARCHITECTURE.md (#5090)
d2f169b
@nolanlawson @jhefferman-sfdc @wjhsf
fix(ssr): fix adjacent text node concatenation (#5079)
8274541 
Co-authored-by: jhefferman-sfdc <83669775+jhefferman-sfdc@users.noreply.github.com>
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
@nolanlawson
docs: fix mistakes in ARCHITECTURE.md (#5103)
6bf7070 
* docs: fix mistakes in ARCHITECTURE.md

Fixes some typos and improves a link.

* Update ARCHITECTURE.md
@nolanlawson
chore(eslint): disallow fdescribe/fit (#5107)
27a2aaa 
Fixes #5106
@nolanlawson @wjhsf
fix(signals): avoid throwing when in check throws (#5105)
dc9f7d3 
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
@nolanlawson
fix(ssr): avoid reserved keyword collision (#5108)
5b0b148
@nolanlawson
chore: release v8.12.4 (#5111)
f29ff6e
@nolanlawson nolanlawson requested a review from a team as a code owner January 8, 2025 19:07
@nolanlawson
Copy link
Contributor Author

nolanlawson commented Jan 8, 2025

/nucleus release

@salesforce-nucleus
Copy link
Contributor

salesforce-nucleus bot commented Jan 8, 2025

✅ All Pre-release Checks Passed

  • ✅ Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy
  • ✅ Check PR is approved
    PR 5112 is approved
  • ✅ Check PR is mergeable
    PR 5112 is mergeable
  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR
  • ✅ Check no conflicting Github release
  • ✅ Check NPM packages have not been released yet
  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts
  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@salesforce-nucleus
Copy link
Contributor

salesforce-nucleus bot commented Jan 8, 2025

🚢 Release Starting

This pull request has been merged and the release of version 8.12.4 is starting.

You can monitor the progress of the release in Nucleus by visiting the following URL.
https://nucleus.uipengsys-public.buildndeliver-s.aws-esvc1-useast2.aws.sfdc.cl/workflows/257839

@salesforce-nucleus salesforce-nucleus bot merged commit f29ff6e into release Jan 8, 2025
18 of 19 checks passed
@salesforce-nucleus salesforce-nucleus bot deleted the nolan/release-20250108-2 branch January 8, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjhsf wjhsf wjhsf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nolanlawson @wjhsf @jhefferman-sfdc