Skip to content

chore!: bump typescript to 5.7.3 #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cardoso wants to merge 4 commits into from
Closed

chore!: bump typescript to 5.7.3 #5137

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0cde6bd
chore: bump typescript to 5.7.3
cardoso Jan 17, 2025
2e8b549
fix: eslint-typescript allowDefaultProject conflict
cardoso Jan 17, 2025
5bc2d99
fix: typescript-eslint projectService: true
cardoso Jan 17, 2025
a16748d
Merge branch 'master' into upgrade-typescript
cardoso Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,7 @@ export default tseslint.config(
},

parserOptions: {
projectService: {
allowDefaultProject: [
// I'm not sure why these files aren't picked up... :\
'packages/@lwc/module-resolver/scripts/test/matchers/to-throw-error-with-code.ts',
'packages/@lwc/module-resolver/scripts/test/matchers/to-throw-error-with-type.ts',
'packages/@lwc/module-resolver/scripts/test/setup-test.ts',
],
Comment on lines -52 to -57
Copy link
Contributor Author

@cardoso cardoso Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now they're picked up and we're also not sure why! 😄

Copy link
Contributor Author

@cardoso cardoso Jan 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this: https://devblogs.microsoft.com/typescript/announcing-typescript-5-7/#searching-ancestor-configuration-files-for-project-ownership

It only affects whatever interfaces with tsserverlibrary's ProjectService (eg: typescript-eslint). Doesn't affect output.

},
projectService: true,
},
Comment on lines +49 to +52
Copy link
Contributor Author

@cardoso cardoso Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third time's a charm.

},

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"rollup": "^4.30.1",
"terser": "^5.37.0",
"tslib": "^2.8.1",
"typescript": "5.4.5",
"typescript": "5.7.3",
"typescript-eslint": "8.19.1",
"vitest": "^2.1.8"
},
Expand Down
10 changes: 6 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2104,9 +2104,11 @@

"@lwc/eslint-plugin-lwc-internal@link:./scripts/eslint-plugin":
version "0.0.0"
uid ""

"@lwc/test-utils-lwc-internals@link:./scripts/test-utils":
version "0.0.0"
uid ""

"@napi-rs/wasm-runtime@0.2.4", "@napi-rs/wasm-runtime@^0.2.4":
version "0.2.4"
Expand Down Expand Up @@ -12167,10 +12169,10 @@ typescript-eslint@8.19.1:
"@typescript-eslint/parser" "8.19.1"
"@typescript-eslint/utils" "8.19.1"

typescript@5.4.5:
version "5.4.5"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.4.5.tgz#42ccef2c571fdbd0f6718b1d1f5e6e5ef006f611"
integrity sha512-vcI4UpRgg81oIRUFwR0WSIHKt11nJ7SAVlYNIu+QpqeyXP+gpQJy/Z4+F0aGxSE4MqwjyXvW/TzgkLAx2AGHwQ==
typescript@5.7.3:
version "5.7.3"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.7.3.tgz#919b44a7dbb8583a9b856d162be24a54bf80073e"
integrity sha512-84MVSjMEHP+FQRPy3pX9sTVV/INIex71s9TL2Gm5FG/WG1SqXeKyZ0k7/blY/4FdOzI12CBy1vGc4og/eus0fw==

typical@^4.0.0:
version "4.0.0"
Expand Down