fix: duplicate behavior for slotted content when no template is present#5174
Merged
jhefferman-sfdc merged 9 commits intomasterfrom Jan 30, 2025
Merged
fix: duplicate behavior for slotted content when no template is present#5174jhefferman-sfdc merged 9 commits intomasterfrom
jhefferman-sfdc merged 9 commits intomasterfrom
Conversation
wjhsf
reviewed
Jan 29, 2025
Comment on lines
+104
to
+106
| _shadowSlottedContent: any, | ||
| _lightSlottedContent: any, | ||
| _scopedSlottedContent: any, |
Contributor
Author
There was a problem hiding this comment.
I had a feeling this might upset you :p
wjhsf
approved these changes
Jan 30, 2025
| _lightSlottedContent: unknown, | ||
| _scopedSlottedContent: unknown, | ||
| Cmp: LightningElementConstructor, | ||
| _instance: unknown |
Contributor
There was a problem hiding this comment.
Suggested change
| _instance: unknown | |
| instance: unknown |
| yield '<template shadowrootmode="open"></template>'; | ||
| yield `<template shadowrootmode="open"></template>`; | ||
| if (shadowSlottedContent) { | ||
| yield shadowSlottedContent(_instance); |
Contributor
There was a problem hiding this comment.
Suggested change
| yield shadowSlottedContent(_instance); | |
| yield shadowSlottedContent(instance); |
| _lightSlottedContent: unknown, | ||
| _scopedSlottedContent: unknown, | ||
| Cmp: LightningElementConstructor, | ||
| _instance: unknown |
Contributor
There was a problem hiding this comment.
Suggested change
| _instance: unknown | |
| instance: unknown |
| emit('<template shadowrootmode="open"></template>'); | ||
| emit(`<template shadowrootmode="open"></template>`); | ||
| if (shadowSlottedContent) { | ||
| shadowSlottedContent(emit, _instance); |
Contributor
There was a problem hiding this comment.
Suggested change
| shadowSlottedContent(emit, _instance); | |
| shadowSlottedContent(emit, instance); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Does this pull request introduce an observable change?
GUS work item
W-17657735