feat(wire): allow arbitrary computed properties in @wire config @W-17206172#5183
Closed
feat(wire): allow arbitrary computed properties in @wire config @W-17206172#5183
Conversation
some of the directory names are too sentence-y
soon params will be valid
will fix in next PR
Contributor
|
Conflicting files |
Contributor
Author
|
Nobody asked for this, and there's some risk in things getting explode-y, so we'll hold off on the implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
In #3955, we updated
@wireto allow configs with computed properties, e.g.{ [symbol]: '$prop' }. Because of the way the config gets compiled, a computed key like[Math.random()]would return a different value every time. To avoid that, the original implementation for computed properties only allowed a limited subset of expressions (specifically, literals andconstvariables). In this PR, we update the compiler to store a snapshot of the computed keys, so that the values do not change. This enables us to now allow any arbitrary value as a config key.As an example, these all used to be forbidden, but are now allowed.
Closes #3956.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item