-
Notifications
You must be signed in to change notification settings - Fork 439
fix: add environment variable to disable LWC version mismatch loglines #5187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nrkruk
merged 8 commits into
salesforce:master
from
nrkruk:nrkruk/fixVersionMismatchWarning
Feb 28, 2025
+19
−0
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7397767
fix: local dev logs LWC mismatch warnings on every SSR request
nrkruk d135dbf
fix: null checks for safety
nrkruk c451d88
fix: tests
nrkruk 55cb8f5
fix: rollup comments
nrkruk 1ed3c8a
Merge branch 'salesforce:master' into nrkruk/fixVersionMismatchWarning
nrkruk f529365
fix: rollup replace
nrkruk 3386121
Merge branch 'salesforce:master' into nrkruk/fixVersionMismatchWarning
nrkruk abae28b
fix: dont remove from engine-dom with rollup
nrkruk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,6 +55,9 @@ function sharedPlugins() { | |
| // This is only used inside @lwc/engine-dom and @lwc/engine-server | ||
| // Elsewhere, it _not_ be replaced, so that it can be replaced later (e.g. in @lwc/engine-core) | ||
| 'process.env.IS_BROWSER': packageName === '@lwc/engine-dom' ? 'true' : 'false', | ||
| ...(packageName === '@lwc/engine-dom' | ||
| ? { 'process.env.SKIP_LWC_VERSION_MISMATCH_CHECK': 'false' } | ||
| : {}), | ||
|
||
| }; | ||
|
|
||
| return [ | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was just being extra cautious - I didn't know how things were compiled (and what is shipped to the browser vs whats available in server side engine). Didn't want to unintentionally break something for this one usecase.