-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add flag for extended scope token syntax @W-17710895 #5211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mechanism of using tokens LGTM. I will let somebody from WCF validate the purpose of this flag and approve the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know someone (rip) who would have demanded tests for this!
it's unused
tag name (x-test) may not match directory name of root component
just removed it yesterday lol
make it more accurate
/nucleus ignore --reason "unrelated __lwc issue in webruntime" |
Details
Users shouldn't, but can provide their own scope tokens. We recently disallowed the use of
.
in scope tokens. To avoid breaking users who rely on that character, we re-introduce the character behind a runtime flag.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item