Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add flag for extended scope token syntax @W-17710895 #5211

Merged
merged 25 commits into from
Feb 28, 2025

Conversation

wjhsf
Copy link
Collaborator

@wjhsf wjhsf commented Feb 11, 2025

Details

Users shouldn't, but can provide their own scope tokens. We recently disallowed the use of . in scope tokens. To avoid breaking users who rely on that character, we re-introduce the character behind a runtime flag.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

@wjhsf wjhsf requested a review from a team as a code owner February 11, 2025 21:05
@wjhsf wjhsf changed the title chore: add flag for extended scope token syntax chore: add flag for extended scope token syntax @W-17710895 Feb 11, 2025
Copy link
Contributor

@ravijayaramappa ravijayaramappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mechanism of using tokens LGTM. I will let somebody from WCF validate the purpose of this flag and approve the PR.

Copy link
Member

@ekashida ekashida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know someone (rip) who would have demanded tests for this!

@wjhsf wjhsf enabled auto-merge (squash) February 14, 2025 22:03
@wjhsf wjhsf disabled auto-merge February 15, 2025 02:16
@wjhsf
Copy link
Collaborator Author

wjhsf commented Feb 28, 2025

/nucleus ignore --reason "unrelated __lwc issue in webruntime"

@wjhsf wjhsf merged commit fa4c927 into master Feb 28, 2025
11 checks passed
@wjhsf wjhsf deleted the wjh/style-token-flag branch February 28, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants