Skip to content

test(engine-server): clean up fixture tests #5219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wjhsf merged 8 commits into from
Feb 13, 2025
Merged

test(engine-server): clean up fixture tests #5219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b77a92d
test(engine-server): remove `feature` feature
wjhsf Feb 12, 2025
d5035b7
chore: remove feature from types
wjhsf Feb 12, 2025
8e612da
chore(tests): remove unused exports from tests
wjhsf Feb 12, 2025
97fcddd
chore: rename x/test modules to x/static
wjhsf Feb 12, 2025
7a52714
chore: use static x-test for root fixture component
wjhsf Feb 12, 2025
f041337
chore: remove tag name that is no longer used
wjhsf Feb 12, 2025
915470c
refactor(test): destructure!
wjhsf Feb 12, 2025
294d0c6
chore: `fixture-test` feels better than `x-test` to make it more clea…
wjhsf Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
23 changes: 3 additions & 20 deletions packages/@lwc/engine-server/src/__tests__/fixtures.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,12 @@ import { rollup } from 'rollup';
import lwcRollupPlugin from '@lwc/rollup-plugin';
import { testFixtureDir, formatHTML } from '@lwc/test-utils-lwc-internals';
import { setFeatureFlagForTest } from '../index';
import type { FeatureFlagName } from '@lwc/features/dist/types';
import type { RollupLwcOptions } from '@lwc/rollup-plugin';
import type * as lwc from '../index';

interface FixtureModule {
tagName: string;
default: typeof lwc.LightningElement;
props?: { [key: string]: any };
features?: any[];
props?: { [key: string]: unknown };
}

vi.setConfig({ testTimeout: 10_000 /* 10 seconds */ });
Expand Down Expand Up @@ -132,20 +129,10 @@ function testFixtures(options?: RollupLwcOptions) {

let result;
let err;
let features: FeatureFlagName[] = [];
try {
const module = (await import(compiledFixturePath)) as FixtureModule;

features = module!.features ?? [];
features.forEach((flag) => {
lwcEngineServer!.setFeatureFlagForTest(flag, true);
});
const { default: module } = (await import(compiledFixturePath)) as FixtureModule;
result = formatHTML(
lwcEngineServer!.renderComponent(
module!.tagName,
module!.default,
config?.props ?? {}
)
lwcEngineServer!.renderComponent('fixture-test', module, config?.props ?? {})
);
} catch (_err: any) {
if (_err?.name === 'AssertionError') {
Expand All @@ -154,10 +141,6 @@ function testFixtures(options?: RollupLwcOptions) {
err = _err?.message || 'An empty error occurred?!';
}

features.forEach((flag) => {
lwcEngineServer!.setFeatureFlagForTest(flag, false);
});

return {
'expected.html': result,
'error.txt': err,
Expand Down
4 changes: 2 additions & 2 deletions ..._tests__/fixtures/adjacent-text-nodes/preserve-comments-off/comments-at-end/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
‍
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/comments-at-end/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions ...__/fixtures/adjacent-text-nodes/preserve-comments-off/comments-then-element/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
‍
<div>
</div>
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...tests__/fixtures/adjacent-text-nodes/preserve-comments-off/comments-then-element/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions .../adjacent-text-nodes/preserve-comments-off/deep-for-each-with-rendered-item/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
ab
<div data-foo="1">
c
</div>
de
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...tures/adjacent-text-nodes/preserve-comments-off/deep-for-each-with-rendered-item/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions .../__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/deep-for-each/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
ab
<div>
c
</div>
de
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...r/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/deep-for-each/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions .../__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/deep-iterator/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
ab
<div>
c
</div>
de
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...r/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/deep-iterator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions ...erver/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/deep/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<div>
abc
</div>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...ine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/deep/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions ...rver/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/deep2/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
ab
<div>
c
</div>
de
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...ne-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/deep2/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions ...er/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/emptier/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
‍
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/emptier/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions ...rver/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/empty/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
‍
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...ne-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/empty/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions ...ver/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/empty1/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
‍
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...e-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/empty1/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions ...ver/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/empty2/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
‍
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...e-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/empty2/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions ...ver/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/empty3/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
‍
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...e-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/empty3/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions ...s__/fixtures/adjacent-text-nodes/preserve-comments-off/html-escaping-single/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
&amp;minus;
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ..._tests__/fixtures/adjacent-text-nodes/preserve-comments-off/html-escaping-single/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions .../__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/html-escaping/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
&amp;minus;
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...r/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/html-escaping/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions .../__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/if-as-sibling/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<div>
‍‍‍
Expand All @@ -7,4 +7,4 @@
‍‍
</div>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...r/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/if-as-sibling/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions .../__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/just-comments/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...r/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/just-comments/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions ...tests__/fixtures/adjacent-text-nodes/preserve-comments-off/lwcIf-as-sibling/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<div>
‍
Expand All @@ -11,4 +11,4 @@
‍‍
</div>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...rc/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/lwcIf-as-sibling/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions ...tests__/fixtures/adjacent-text-nodes/preserve-comments-off/nonempty-dynamic/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
haha0true
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...rc/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/nonempty-dynamic/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions ...ixtures/adjacent-text-nodes/preserve-comments-off/nonempty-literals-outside/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
totoyolototoyolo
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...s__/fixtures/adjacent-text-nodes/preserve-comments-off/nonempty-literals-outside/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions ...r/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/nonempty/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
yolototo
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/nonempty/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
4 changes: 2 additions & 2 deletions .../src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/nonempty1/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<x-comments-text>
<fixture-test>
<template shadowrootmode="open">
<span>
bar
</span>
</template>
</x-comments-text>
</fixture-test>
2 changes: 0 additions & 2 deletions ...erver/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-off/nonempty1/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export const tagName = 'x-comments-text';
export { default } from 'x/comments-text';
export * from 'x/comments-text';
Loading
Loading