Code

feat: add lwc:on directive#5228

Code

Open

gaurav-rk9 wants to merge 47 commits intosalesforce:mastersalesforce/lwc:masterfrom gaurav-rk9:lwc_ongaurav-rk9/lwc:lwc_onCopy head branch name to clipboard

+2,183-32

Commits

Commits on Feb 27, 2025

• test(integration-karma): add integration tests for lwc:on directive

  gaurav-rk9

  committed
  af5ec53

  Copy full SHA for af5ec53

• feat(engine-core): add optional dynamicOn property to VNodeData interface

  gaurav-rk9

  committed
  43645d6

  Copy full SHA for 43645d6

• feat(engine-core): add patching utilities for dynamic event listeners

  gaurav-rk9

  committed
  e448481

  Copy full SHA for e448481

• feat(engine-core): update hydration and rendering to patch dynamic event listeners

  gaurav-rk9

  committed
  d80984f

  Copy full SHA for d80984f

• feat(shared): export Detached Object.prototype.propertyIsEnumerable from language.ts

  gaurav-rk9

  committed
  aec5dc7

  Copy full SHA for aec5dc7

• fix(engine-core): use propertyIsEnumerable from @lwc/shared

  gaurav-rk9

  committed
  96df273

  Copy full SHA for 96df273

• feat(template-compiler): add type and helper functions for OnDirective AST node

  gaurav-rk9

  committed
  154a932

  Copy full SHA for 154a932

• feat: throw error when lwc:on is used on a non-root <template> element

  gaurav-rk9

  committed
  69bb3c2

  Copy full SHA for 69bb3c2

• feat: add parsing of lwc:on directive

  gaurav-rk9

  committed
  d6a0a6a

  Copy full SHA for d6a0a6a

Commits on Feb 28, 2025

• feat: throw error when declarative event listeners are used alongside lwc:on

  gaurav-rk9

  committed
  80b6a07

  Copy full SHA for 80b6a07

• feat(template-compiler): add code generation for lwc:on directive

  gaurav-rk9

  committed
  c665ac0

  Copy full SHA for c665ac0

• feat(engine-core): add basic implementation of freeze render API

  gaurav-rk9

  committed
  c6721f9

  Copy full SHA for c6721f9

• docs(engine-core): add comment in patchDynamicEventListeners regarding freezing assumption

  gaurav-rk9

  committed
  52516ee

  Copy full SHA for 52516ee

Commits on Mar 2, 2025

• Apply suggestions from code review

  Show description for e036dd9
  

  3 peopleauthored
  e036dd9

  Copy full SHA for e036dd9

• test(integration-karma): fix ignored properties and event type case tests

  gaurav-rk9

  committed
  3b7d35a

  Copy full SHA for 3b7d35a

• test(integration-karma): add tests to verify re-rendering behaviour

  gaurav-rk9

  committed
  35723ab

  Copy full SHA for 35723ab

• test(integration-karma): add a seperate test for object passed as public property

  Show description for 8a26014
  gaurav-rk9

  committed
  8a26014

  Copy full SHA for 8a26014

• fix: fix @api issues by removing freeze api and adding copy api

  gaurav-rk9

  committed
  e4a492d

  Copy full SHA for e4a492d

Commits on Mar 3, 2025

• style: apply suggestion from code review - consistent error names

  gaurav-rk9

  committed
  e2362b8

  Copy full SHA for e2362b8

• test(integration-karma): add missing test component x/publicProp

  gaurav-rk9

  committed
  46ebc04

  Copy full SHA for 46ebc04

• style(engine-core): rename variables related to patching and add comments for better readability

  gaurav-rk9

  committed
  785100a

  Copy full SHA for 785100a

• fix(engine-core): add missing negation operator in patchDynamicEventListener

  gaurav-rk9

  committed
  eac5f81

  Copy full SHA for eac5f81

• docs(template-compiler): add comment explaining the check used to know lwc:on is used with onfoo

  gaurav-rk9

  committed
  e911556

  Copy full SHA for e911556

• docs(template-compiler): add comment explaining onDirective codegen in databag

  gaurav-rk9

  committed
  ef2b742

  Copy full SHA for ef2b742

• fix(engine-core): change prevInp to prevOut in comparision

  gaurav-rk9

  committed
  884037c

  Copy full SHA for 884037c

• test(integration-karma): expand re-render tests to include the case when object is mutated

  gaurav-rk9

  committed
  2ee9351

  Copy full SHA for 2ee9351

Commits on Mar 4, 2025

• test(template-compiler): add snapshot tests for template-compiler

  gaurav-rk9

  committed
  56eed25

  Copy full SHA for 56eed25

• test(integration-karma): move catchUnhandledRejectionsAndError inside the specific describe

  Show description for 82cd9c8
  gaurav-rk9

  committed
  82cd9c8

  Copy full SHA for 82cd9c8

• test(integration-karma): add re-render tests for lwc:on used inside for:each loop

  gaurav-rk9

  committed
  efa9a5a

  Copy full SHA for efa9a5a

• test(integration-karma): correct 'this' in rerenderLoop.js

  gaurav-rk9

  committed
  528f63a

  Copy full SHA for 528f63a

• fix: move copy api's work to codeGen and patching

  gaurav-rk9

  committed
  c4cdbd5

  Copy full SHA for c4cdbd5

• refactor: remove dead code

  gaurav-rk9

  committed
  7603842

  Copy full SHA for 7603842

Commits on Mar 5, 2025

• fix: Apply suggestions from code review - <> in error message

  Show description for 724f925
  

  gaurav-rk9

  and

  wjhsf

  authored
  724f925

  Copy full SHA for 724f925

• feat: add template-compiler flag enableLwcOn

  gaurav-rk9

  committed
  cb1645c

  Copy full SHA for cb1645c

• test(integration-karma): modify test to include <> in error message

  gaurav-rk9

  committed
  d2f2ce8

  Copy full SHA for d2f2ce8

• Merge branch 'master' into lwc_on

  gaurav-rk9

  committed
  2535c10

  Copy full SHA for 2535c10

• test(integration-karma): remove console log spy

  gaurav-rk9

  committed
  88e9a0f

  Copy full SHA for 88e9a0f

• perf(engine-core): change delete obj[x] to obj[x] = undefined

  gaurav-rk9

  committed
  abcce1b

  Copy full SHA for abcce1b

• test(integration-karma): simplify tests by re-using spies

  gaurav-rk9

  committed
  021a922

  Copy full SHA for 021a922

• chore: increase allowed bundlesize limit

  gaurav-rk9

  committed
  247e660

  Copy full SHA for 247e660

• test(template-compiler): fix error codes in snapshots

  gaurav-rk9

  committed
  528b1ca

  Copy full SHA for 528b1ca

• fix: change throw new Error to logError

  gaurav-rk9

  committed
  1a5236b

  Copy full SHA for 1a5236b

• docs(engine-core): add comments explaining dynamicOn has null proto and own enumerbale props

  gaurav-rk9

  committed
  2e5bf3d

  Copy full SHA for 2e5bf3d

Commits on Mar 6, 2025

• test(integration-karma): add tests for objects with computed key

  gaurav-rk9

  committed
  5a2358b

  Copy full SHA for 5a2358b

• fix(engine-core): modify patch logic to differentiate prop value = undefined and prop not existing

  gaurav-rk9

  committed
  9596f94

  Copy full SHA for 9596f94

• test(integration-karma): add tests where arg has property with value non-function/ whose eval throws

  gaurav-rk9

  committed
  e5a2cda

  Copy full SHA for e5a2cda

• test(integration-karma): simplify value evaluation throws tests

  gaurav-rk9

  committed
  523ac07

  Copy full SHA for 523ac07