feat(ssr): implement light DOM slotted content in default template#5240
Closed
feat(ssr): implement light DOM slotted content in default template#5240
Conversation
wjhsf
commented
Feb 26, 2025
wjhsf
commented
Feb 26, 2025
Comment on lines
+53
to
+55
| static delegatesFocus?: boolean; | ||
| static formAssociated?: boolean; | ||
| static shadowSupportMode?: 'any' | 'reset' | 'native'; |
Contributor
Author
There was a problem hiding this comment.
This is just bonus stuff from engine-core that I noticed was missing here.
Contributor
Author
|
Closing as we don't want to change this behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This implementation is divergent behavior from
engine-server. Inslots-basic/implicit-no-template, we have a light DOM component with no template that receives slotted content. Inengine-server, the content is not rendered. But with this change, it is rendered inssr-compiler.Note: this PR also reorders the parameters of
generateMarkupso that I could more easily DRY the types.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item