Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ssr): update generateMarkup type defs #5242

Merged
merged 6 commits into from
Feb 27, 2025
Merged

Conversation

wjhsf
Copy link
Collaborator

@wjhsf wjhsf commented Feb 26, 2025

Details

With all the indirection between the generated code fragments (and their lack of types) and the transmogrifier, the types in render.ts got a bit out of date. I updated them to be accurate and tried to DRY it up a bit. But it's not that repetitive, so the abstraction might be too much in the other direction? 🤷

Note that TypeScript knows to expand the rest params, so that the tooltips still look as if the functions had been defined the regular way.
screenshot of VS Code tooltip for GenerateMarkupAsyncYield

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

@wjhsf wjhsf marked this pull request as ready for review February 26, 2025 21:33
@wjhsf wjhsf requested a review from a team as a code owner February 26, 2025 21:33
@wjhsf
Copy link
Collaborator Author

wjhsf commented Feb 27, 2025

/nucleus ignore --reason "Unrelated __lwc failure in webruntime"

@wjhsf wjhsf merged commit 6eee0d1 into master Feb 27, 2025
11 checks passed
@wjhsf wjhsf deleted the wjh/clean-up-render branch February 27, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants