chore(ssr): update generateMarkup
type defs
#5242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
With all the indirection between the generated code fragments (and their lack of types) and the transmogrifier, the types in
render.ts
got a bit out of date. I updated them to be accurate and tried to DRY it up a bit. But it's not that repetitive, so the abstraction might be too much in the other direction? 🤷Note that TypeScript knows to expand the rest params, so that the tooltips still look as if the functions had been defined the regular way.

Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item