-
Notifications
You must be signed in to change notification settings - Fork 439
fix(ssr): global attribute disparities #5247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
03a7d22
chore: testing hydration
jhefferman-sfdc 491420e
chore: added tests
jhefferman-sfdc 3a8cef5
Merge branch 'master' into jhefferman/attribute-props
jhefferman-sfdc 8ca936b
chore: added dedicated tests for v1/2 delta
jhefferman-sfdc 6546b7e
chore: modified public property test
jhefferman-sfdc 1264593
fix: tabindex corrections, additional tests
jhefferman-sfdc 94442fc
chore: minor corrections
jhefferman-sfdc a7d359f
fix: prettier
jhefferman-sfdc ec40970
chore: update undeclared test
jhefferman-sfdc 17ffe1a
fix: hydration test
jhefferman-sfdc a54ee8f
Merge branch 'master' into jhefferman/attribute-props
jhefferman-sfdc 37bbb04
chore: added hydration tests and v1/2 pathing
jhefferman-sfdc dc7ed4b
chore: test debug
jhefferman-sfdc 3fd5059
chore: check error length
jhefferman-sfdc 09ef312
chore: revert hydration failure test
jhefferman-sfdc 5733e60
chore: change path strat
jhefferman-sfdc 7370ec3
chore: test correction, production mode
jhefferman-sfdc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
..._tests__/fixtures/attribute-global-html/as-component-prop/without-@api-values/config.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "entry": "x/component", | ||
divmain marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "ssrFiles": { | ||
| "error": "error-ssr.txt", | ||
| "expected": "expected-ssr.html" | ||
| } | ||
| } | ||
Empty file.
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.