Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ssr): use real error messages for errors @W-17408217 #5249

Merged
merged 3 commits into from
Feb 28, 2025
Merged

chore(ssr): use real error messages for errors @W-17408217 #5249

merged 3 commits into from
Feb 28, 2025

Conversation

wjhsf
Copy link
Collaborator

@wjhsf wjhsf commented Feb 28, 2025

Details

Updates ssr-compiler to use the shared error messages, for a more consistent user experience.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

@wjhsf wjhsf marked this pull request as ready for review February 28, 2025 18:31
@wjhsf wjhsf requested a review from a team as a code owner February 28, 2025 18:31
divmain
divmain approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@divmain divmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs a couple of test updates. Otherwise, looks great!

@wjhsf wjhsf enabled auto-merge (squash) February 28, 2025 19:00
@wjhsf
Copy link
Collaborator Author

wjhsf commented Feb 28, 2025

/nucleus ignore --reason "unrelated __lwc issue in webruntime"

@wjhsf wjhsf merged commit c04b0b7 into master Feb 28, 2025
11 checks passed
@wjhsf wjhsf deleted the wjh/real-errors branch February 28, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divmain divmain divmain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjhsf @divmain