chore(rollup): use less confusing implementation for default true#5263
Merged
chore(rollup): use less confusing implementation for default true#5263
Conversation
turns out I didn't fully understand the original implementation!
jhefferman-sfdc
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Just noticed that the implementation for the
enableStaticContentOptimizationoption was confusing. Neither the code comment nor the review comment were super clear. But the intention is just to make it default totrue, so I just made it simpler / explicit.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item