@W-17592100 chore: run unit tests in production mode #5270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are a lot of failures that we'll get to later
wjhsf
commented
Mar 6, 2025
Coverage will always be lower because we have a ton of `NODE_ENV !== production checks`, but no `===` checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This sets us up to address #5134 by running unit tests in production mode in CI, and fixes everything except
engine-server(which is the scope of #5134).Thanks @cardoso for figuring out how to get vitest to play nice with the
packages/lwctests! I stole your work from #5269.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item