Skip to content

chore: simplify style dedupe config#5271

Merged
wjhsf merged 7 commits intomasterfrom
wjh/simpler-style-dedupe-config
Mar 27, 2025
Merged

chore: simplify style dedupe config#5271
wjhsf merged 7 commits intomasterfrom
wjh/simpler-style-dedupe-config

Conversation

@wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Mar 6, 2025

Details

A fast follow to #5264 with a simplification to the config that I thought of after the PR was merged.

Now we just have a single parameter, styleDedupe that accepts a string or boolean value. If a string is provided, deduplication is performed with the provided prefix. If true is provided, deduplication is performed with no prefix. Otherwise, deduplication is nor performed.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

@wjhsf wjhsf requested a review from a team as a code owner March 6, 2025 21:24
Copy link
Contributor

@divmain divmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to change the test script so that styleDedupePrefix works correctly in config.json (see fixtures/style-dedupe-with-prefix).

wjhsf and others added 2 commits March 6, 2025 20:56
@wjhsf wjhsf requested a review from divmain March 7, 2025 20:46
@wjhsf
Copy link
Contributor Author

wjhsf commented Mar 24, 2025

I got sick, so this is no longer a fast follow. 🫠 Still think it's a good simplification to the API tho.

@wjhsf
Copy link
Contributor Author

wjhsf commented Mar 24, 2025

/nucleus ignore --reason "expected failure due to this change"

Copy link
Contributor

@divmain divmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@wjhsf
Copy link
Contributor Author

wjhsf commented Mar 27, 2025

/nucleus ignore --reason "This PR intentionally breaks webruntime"

@wjhsf wjhsf merged commit 03ca787 into master Mar 27, 2025
11 checks passed
@wjhsf wjhsf deleted the wjh/simpler-style-dedupe-config branch March 27, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants