Skip to content

chore: expose lwc-style register util #5277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wjhsf merged 3 commits into from
Mar 11, 2025
Merged

chore: expose lwc-style register util #5277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
391d13b
chore: avoid changing files on commit
wjhsf Mar 7, 2025
a52d5ec
chore: allow packages to export additional files
wjhsf Mar 7, 2025
c075aa3
chore(ssr-client-utils): expose register util
wjhsf Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@
},
"lint-staged": {
"*.{js,mjs,ts}": "eslint --cache",
"*.{css,js,json,md,mjs,ts,yaml,yml}": "prettier --write",
"{packages/**/package.json,scripts/tasks/check-and-rewrite-package-json.js}": "node ./scripts/tasks/check-and-rewrite-package-json.js",
"{LICENSE-CORE.md,**/LICENSE.md,yarn.lock,scripts/tasks/generate-license-files.js,scripts/shared/bundled-dependencies.js}": "node ./scripts/tasks/generate-license-files.js",
"*.{css,js,json,md,mjs,ts,yaml,yml}": "prettier --check",
"{packages/**/package.json,scripts/tasks/check-and-rewrite-package-json.js}": "node ./scripts/tasks/check-and-rewrite-package-json.js --test",
"{LICENSE-CORE.md,**/LICENSE.md,yarn.lock,scripts/tasks/generate-license-files.js,scripts/shared/bundled-dependencies.js}": "node ./scripts/tasks/generate-license-files.js --test",
Comment on lines +80 to +82
Copy link
Contributor Author

@wjhsf wjhsf Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes git commit to only validate files pre-commit, rather than edit them. The auto-changing annoyed me when I tried to test this change!

"*.{only,skip}": "eslint --cache --plugin '@lwc/eslint-plugin-lwc-internal' --rule '@lwc/lwc-internal/forbidden-filename: error'"
},
"workspaces": [
Expand Down
3 changes: 2 additions & 1 deletion packages/@lwc/ssr-client-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
"types": "dist/index.d.ts",
"files": [
"dist/**/*.js",
"dist/**/*.d.ts"
"dist/**/*.d.ts",
"register-lwc-style.js"
],
"scripts": {
"build": "rollup --config ../../../scripts/rollup/rollup.config.js",
Expand Down
2 changes: 1 addition & 1 deletion scripts/tasks/check-and-rewrite-package-json.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ for (const dir of globSync('./packages/@lwc/*')) {
module: 'dist/index.js',
types: 'dist/index.d.ts',
// It's important _not_ to use `./dist` here (with the `./`), because npm does not understand that
files: ['dist/**/*.js', 'dist/**/*.d.ts'],
files: Array.from(new Set(['dist/**/*.js', 'dist/**/*.d.ts', ...pkg.files])),
scripts: {
build: 'rollup --config ../../../scripts/rollup/rollup.config.js',
dev: 'rollup --config ../../../scripts/rollup/rollup.config.js --watch --no-watch.clearScreen',
Expand Down