chore: use __lwc for transmogrified function names
#5278
+35
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
commented
Mar 7, 2025
| const TMPL_FN_PATTERN = /tmpl($\d+)?/; | ||
| const GEN_MARKUP_OR_GEN_SLOTTED_CONTENT_PATTERN = | ||
| /(?:generateMarkup|generateSlottedContent)($\d+)?/; | ||
| const TRANSMOGRIFY_TARGET = /^__lwc(GenerateMarkup|GenerateSlottedContent|Tmpl)(?:\$\d+)?$/; |
There was a problem hiding this comment.
Having two regex to check for three nearly identical things seemed silly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When we transmogrify the SSR compiler's output, we only want to target functions created by the compiler, not the component's implementation. We check for specific function names, but technically a component could implement a function with the same name (or even containing the same name, like
omgwtftmplbbq, because we don't use^$in the regex check). However, we already prevent components from using names starting with__lwc, so we can prevent accidental transmogrification by using that namespace for the functions we own.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item