chore: extra guards process.env @W-17994335#5281
Merged
Conversation
evidently some places have `process` but not `process.env`
jye-sf
reviewed
Mar 10, 2025
| if ( | ||
| typeof process === 'object' && | ||
| typeof process?.env === 'object' && | ||
| process.env && |
Contributor
There was a problem hiding this comment.
nit: if typeof process?.env === 'object', isn't it almost guaranteed that process.env is truthy, making this third check unnecessary? I think the only possible way for this to be falsy is if process.env == document.all right?
Contributor
Author
There was a problem hiding this comment.
It would be document.all or null. And it would be weird, but not entirely implausible, if somebody did process.env = null somewhere to avoid exposing env vars.
tbh we just made an evidently bad assumption that typeof process === 'object' implies process = { env : {} }, so now I don't wanna assume anything.
jye-sf
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
evidently some places have
processbut notprocess.envDetails
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item