Merged
Conversation
jhefferman-sfdc
changed the base branch from
jhefferman/wire-sequence-test
to
master
wjhsf
reviewed
Mar 19, 2025
packages/@lwc/engine-server/src/__tests__/fixtures/wire/invocation-sequence/prop/expected.html
Outdated
Show resolved
Hide resolved
divmain
approved these changes
Mar 19, 2025
| instance.connectedCallback(); | ||
| __mutationTracker.disable(instance); | ||
| } | ||
| ${/*connect wire*/ is.statement} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
SSRv2 wires were being invoked before component properties. If a property is both @api and @wire mutated, the api mutation takes precedence and the wire update is lost. This PR ensures wire invocation is last for V1/CSR parity.
This impacted a few scenarios, namely W-17953862.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-17953862