jhefferman/release release 8.18.2#5351
Closed
jhefferman-sfdc wants to merge 10 commits intoreleasefrom
Closed
Conversation
* test(integration-karma): add integration tests for lwc:on directive * feat(engine-core): add optional dynamicOn property to VNodeData interface * feat(engine-core): add patching utilities for dynamic event listeners * feat(engine-core): update hydration and rendering to patch dynamic event listeners * feat(shared): export Detached Object.prototype.propertyIsEnumerable from language.ts * fix(engine-core): use propertyIsEnumerable from @lwc/shared * feat(template-compiler): add type and helper functions for OnDirective AST node * feat: throw error when lwc:on is used on a non-root <template> element * feat: add parsing of lwc:on directive * feat: throw error when declarative event listeners are used alongside lwc:on * feat(template-compiler): add code generation for lwc:on directive * feat(engine-core): add basic implementation of freeze render API * docs(engine-core): add comment in patchDynamicEventListeners regarding freezing assumption * Apply suggestions from code review Add comments, improve readability of statements, correct copyright year Co-authored-by: Dale Bustad <dale@divmain.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * test(integration-karma): fix ignored properties and event type case tests * test(integration-karma): add tests to verify re-rendering behaviour * test(integration-karma): add a seperate test for object passed as public property add a seperate test for object passed as public property and refactors other tests to be independent * fix: fix @api issues by removing freeze api and adding copy api * style: apply suggestion from code review - consistent error names * test(integration-karma): add missing test component x/publicProp * style(engine-core): rename variables related to patching and add comments for better readability * fix(engine-core): add missing negation operator in patchDynamicEventListener * docs(template-compiler): add comment explaining the check used to know lwc:on is used with onfoo * docs(template-compiler): add comment explaining onDirective codegen in databag * fix(engine-core): change prevInp to prevOut in comparision * test(integration-karma): expand re-render tests to include the case when object is mutated * test(template-compiler): add snapshot tests for template-compiler * test(integration-karma): move catchUnhandledRejectionsAndError inside the specific describe Having in top-level may cause false success * test(integration-karma): add re-render tests for lwc:on used inside for:each loop * test(integration-karma): correct 'this' in rerenderLoop.js * fix: move copy api's work to codeGen and patching * refactor: remove dead code * fix: Apply suggestions from code review - <> in error message Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * feat: add template-compiler flag enableLwcOn * test(integration-karma): modify test to include <> in error message * test(integration-karma): remove console log spy * perf(engine-core): change delete obj[x] to obj[x] = undefined * test(integration-karma): simplify tests by re-using spies * chore: increase allowed bundlesize limit * test(template-compiler): fix error codes in snapshots * fix: change throw new Error to logError * docs(engine-core): add comments explaining dynamicOn has null proto and own enumerbale props * test(integration-karma): add tests for objects with computed key * fix(engine-core): modify patch logic to differentiate prop value = undefined and prop not existing * test(integration-karma): add tests where arg has property with value non-function/ whose eval throws * test(integration-karma): simplify value evaluation throws tests * chore: bump CI * fix: integration tests in Firefox --------- Co-authored-by: Gaurav Kochar <gauravrkochar@gmail.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
jhefferman-sfdc
force-pushed
the
release
branch
from
4e57f75 to
8c03e50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-18328598