Skip to content

chore: remove structuredClone workaround #5367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wjhsf merged 2 commits into from
May 19, 2025
Merged

chore: remove structuredClone workaround #5367

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59116a5
chore: remove structuredClone workaround
wjhsf Apr 10, 2025
0d05c08
Merge branch 'master' into wjh/structuredClone
wjhsf May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions packages/@lwc/template-compiler/src/codegen/codegen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,6 @@ import type {
import type { APIVersion } from '@lwc/shared';
import type { Node } from 'estree';

// structuredClone is only available in Node 17+
// https://developer.mozilla.org/en-US/docs/Web/API/structuredClone#browser_compatibility
const doStructuredClone =
typeof structuredClone === 'function'
? structuredClone
: (obj: any) => JSON.parse(JSON.stringify(obj));

type RenderPrimitive =
| 'iterator'
| 'flatten'
Expand Down Expand Up @@ -649,7 +642,7 @@ export default class CodeGen {
if (this.state.config.experimentalComplexExpressions) {
// Cloning here is necessary because `this.replace()` is destructive, and we might use the
// node later during static content optimization
expression = doStructuredClone(expression);
expression = structuredClone(expression);
return bindComplexExpression(expression as ComplexExpression, this);
}

Expand All @@ -659,7 +652,7 @@ export default class CodeGen {

// Cloning here is necessary because `this.replace()` is destructive, and we might use the
// node later during static content optimization
expression = doStructuredClone(expression);
expression = structuredClone(expression);
// TODO [#3370]: when the template expression flag is removed, the
// ComplexExpression type should be redefined as an ESTree Node. Doing
// so when the flag is still in place results in a cascade of required
Expand Down