Conversation
jye-sf
added
nomerge
work-in-progress
wjhsf
reviewed
Jul 7, 2025
package.json
Outdated
| "tslib": "^2.8.1", | ||
| "typescript": "5.8.2", | ||
| "typescript-eslint": "8.29.1", | ||
| "typescript": "5.8.3", |
Contributor
There was a problem hiding this comment.
Because we're a library, bumping our version of TypeScript can be a potentially breaking change at any point.
We're technically supposed to be on v5.4.5, but looks like we accidentally bumped months ago. If nobody's complained, we can just leave it at 5.8.2.
Contributor
Author
There was a problem hiding this comment.
I did not know that. Yeah we can leave it at 5.8.2. I'm wondering if we can make it more obvious that this is a breaking change.....unit test?.....
Contributor
|
Replaced by #5413. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Weekly dependency upgrades
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item