Skip to content

fix: dudupe light scoped issue, hydration coverage #5438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhefferman-sfdc merged 7 commits into from
Aug 1, 2025
Merged

fix: dudupe light scoped issue, hydration coverage #5438

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b91f42e
fix: dudupe light scoped issue, hydration coverage
jhefferman-sfdc Jul 31, 2025
b7673c8
fix: prettier, dedicated dedupe test
jhefferman-sfdc Jul 31, 2025
a27e604
Merge branch 'master' into jhefferman/dedupe-coverage-scope-token-fix
jhefferman-sfdc Jul 31, 2025
5802b89
fix: missing tests
jhefferman-sfdc Jul 31, 2025
d99a6e4
Merge branch 'master' into jhefferman/dedupe-coverage-scope-token-fix
jhefferman-sfdc Jul 31, 2025
6a7c9e6
fix: review comments
jhefferman-sfdc Aug 1, 2025
1c695dc
Merge branch 'master' into jhefferman/dedupe-coverage-scope-token-fix
jhefferman-sfdc Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions ...__tests__/fixtures/attribute-class/with-scoped-styles-only-in-child/dynamic/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
Expand All @@ -29,7 +29,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
Expand All @@ -41,7 +41,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
Expand All @@ -53,7 +53,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
Expand All @@ -65,7 +65,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
Expand All @@ -77,7 +77,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
Expand All @@ -89,7 +89,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
Expand All @@ -101,7 +101,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
Expand All @@ -113,7 +113,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
Expand All @@ -125,7 +125,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="bar foo lwc-5h3d35cke7v">
</div>
Expand All @@ -137,7 +137,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="baz foo lwc-5h3d35cke7v">
</div>
Expand All @@ -149,7 +149,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="bar foo lwc-5h3d35cke7v">
</div>
Expand All @@ -161,7 +161,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="bar foo lwc-5h3d35cke7v">
</div>
Expand All @@ -173,7 +173,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="BaR FOO lwc-5h3d35cke7v">
</div>
Expand All @@ -185,7 +185,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="foo lwc-5h3d35cke7v">
</div>
Expand All @@ -197,7 +197,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="foo lwc-5h3d35cke7v">
</div>
Expand All @@ -209,7 +209,7 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="&quot;'<&amp; lwc-5h3d35cke7v">
</div>
Expand Down
18 changes: 9 additions & 9 deletions .../__tests__/fixtures/attribute-class/with-scoped-styles-only-in-child/static/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,71 +13,71 @@
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
</template>
</x-child>
<x-child class="lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
</template>
</x-child>
<x-child class="foo lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
</template>
</x-child>
<x-child class="foo lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
</template>
</x-child>
<x-child class="bar foo lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
</template>
</x-child>
<x-child class="bar foo lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
</template>
</x-child>
<x-child class="BAR BaZ FoA lwc-5h3d35cke7v-host" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
</template>
</x-child>
<x-child class="lwc-5h3d35cke7v-host tabs" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
</template>
</x-child>
<x-child class="lwc-5h3d35cke7v-host newlines" data-lwc-host-scope-token="lwc-5h3d35cke7v-host">
<template shadowrootmode="open">
<lwc-style style-id="lwc-style--0">
<lwc-style class="lwc-5h3d35cke7v" style-id="lwc-style--0">
</lwc-style>
<div class="lwc-5h3d35cke7v">
</div>
Expand Down
Loading