test(wtr): replace TestUtils/test-utils with regular file module#5476
Merged
test(wtr): replace TestUtils/test-utils with regular file module#5476
Conversation
It makes it much more clear where things come from.
instead of weird fake module
instead of weird fake module
instead of weird fake module
wjhsf
commented
Sep 2, 2025
| DISABLE_SYNTHETIC_SHADOW_SUPPORT_IN_COMPILER, | ||
| } from '../../helpers/options.js'; | ||
|
|
||
| const UTILS = fileURLToPath(new URL('../../helpers/utils.js', import.meta.url)); |
Contributor
Author
There was a problem hiding this comment.
This is the only real change. Everything else is just changes to imports.
wjhsf
commented
Sep 2, 2025
Contributor
Author
There was a problem hiding this comment.
Previous PR was supposed to rename lwc.mjs to lwc.js; apparently lwc.js was added but this was not removed.
rax-it
approved these changes
Sep 2, 2025
Contributor
Author
Web Test Runner loads each |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Some tests rely on the
TestUtilsglobal object. Some import from the faketest-utilsmodule. Both are unnecessary indirection when we can just import directly using a relative file path.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item