Merged
Conversation
jhefferman-sfdc
changed the title
Contributor
Author
|
/nucleus ignore -m "unrelated failure" |
wjhsf
approved these changes
Sep 9, 2025
jhefferman-sfdc
commented
Sep 10, 2025
| $cmp.state.isTrue | ||
| ? api_text(api_dynamic_text($cmp.foo) + api_dynamic_text($cmp.bar)) | ||
| ? api_text( | ||
| api_dynamic_text($cmp.foo) + " " + api_dynamic_text($cmp.bar) |
Contributor
Author
There was a problem hiding this comment.
@jmsjtu - you asked about this in the PR review. I double checked and this expected output now aligns with what the legacy expression parser produces. In other words, it is now correct and it was incorrect before this change.
Contributor
There was a problem hiding this comment.
I just wanna say hi to the future person coming here because of an investigation.
Contributor
Author
There was a problem hiding this comment.
On the contrary! The very existence of this change means such an investigation may never occur!
Contributor
Author
|
/nucleus ignore -m "unrelated failure" |
Contributor
|
⚠ The test stage has a status of running, which cannot be ignored. |
wjhsf
approved these changes
Sep 10, 2025
Contributor
Author
|
/nucleus ignore -m "unrelated failures" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Reworked CTE implementation with HTML compliant syntax:
For additional understanding on why this change was made, see the KT by Dale Bustad: https://docs.google.com/document/d/1K52FRJuJqAbyA-rVXfeGSZ3SHJRNCXog7Qwfk2BSB9s/edit?tab=t.6clsnsapoml8#heading=h.r2ozu3q610ub
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-16824701