salesforce · wjhsf · Sep 16, 2025 · Aug 28, 2025 · Sep 2, 2025 · Sep 2, 2025
@@ -362,14 +362,8 @@ export default tseslint.config(
                 lwcRuntimeFlags: true,
                 process: true,
                 ...globals.browser,
-                ...globals.jasmine,
             },
         },
-
-        rules: {
-            'no-var': 'off',
-            'prefer-rest-params': 'off',
-        },
     },
     {
         files: ['packages/@lwc/integration-karma/**'],
@@ -384,11 +378,6 @@ export default tseslint.config(
                 ...globals.jasmine,
             },
         },
-
-        rules: {
-            'no-var': 'off',
-            'prefer-rest-params': 'off',
-        },
     },
     {
         files: ['packages/@lwc/synthetic-shadow/**'],

@@ -0,0 +1,37 @@
+import { spyOn, fn } from '@vitest/spy';
+
+/**
+ * Adds the jasmine interfaces we use in the Karma tests to a Vitest spy.
+ * Should ultimately be removed and tests updated to use Vitest spies.
+ * @param {import('@vitest/spy').MockInstance}
+ */
+function jasmineSpyAdapter(spy) {
+    Object.defineProperties(spy, {
+        and: { get: () => spy },
+        calls: { get: () => spy.mock.calls },
+        returnValue: { value: () => spy.mockReturnValue() },
+        // calling mockImplementation() with nothing restores the original
+        callThrough: { value: () => spy.mockImplementation() },
+        callFake: { value: (impl) => spy.mockImplementation(impl) },
+    });
+
+    Object.defineProperties(spy.mock.calls, {
+        // Must be non-enumerable for equality checks to work on array literal expected values
+        allArgs: { value: () => spy.mock.calls },
+        count: { value: () => spy.mock.calls.length },
+        reset: { value: () => spy.mockReset() },
+        argsFor: { value: (index) => spy.mock.calls.at(index) },
+    });
+
+    return spy;
+}
+
+export const jasmineSpyOn = (object, prop) => jasmineSpyAdapter(spyOn(object, prop));
+export const jasmine = {
+    any: expect.any,
+    arrayWithExactContents: () => {
+        throw new Error('TODO: jasmine.arrayWithExactContents');
+    },
+    createSpy: (name, impl) => jasmineSpyAdapter(fn(impl)),
+    objectContaining: expect.objectContaining,
+};
@@ -1,7 +1,6 @@
 // This import ensures that the global `Mocha` object is present for mutation.
 import { JestAsymmetricMatchers, JestChaiExpect, JestExtend } from '@vitest/expect';
 import * as chai from 'chai';
-import { spyOn, fn } from '@vitest/spy';
 import { registerCustomMatchers } from './matchers/index.js';
 import { initSignals } from './signals.js';
 
@@ -15,44 +14,8 @@ chai.use(JestChaiExpect);
 chai.use(JestAsymmetricMatchers);
 // add our custom matchers
 chai.use(registerCustomMatchers);
-
-/**
- * Adds the jasmine interfaces we use in the Karma tests to a Vitest spy.
- * Should ultimately be removed and tests updated to use Vitest spies.
- * @param {import('@vitest/spy').MockInstance}
- */
-function jasmineSpyAdapter(spy) {
-    Object.defineProperties(spy, {
-        and: { get: () => spy },
-        calls: { get: () => spy.mock.calls },
-        returnValue: { value: () => spy.mockReturnValue() },
-        // calling mockImplementation() with nothing restores the original
-        callThrough: { value: () => spy.mockImplementation() },
-        callFake: { value: (impl) => spy.mockImplementation(impl) },
-    });
-
-    Object.defineProperties(spy.mock.calls, {
-        // Must be non-enumerable for equality checks to work on array literal expected values
-        allArgs: { value: () => spy.mock.calls },
-        count: { value: () => spy.mock.calls.length },
-        reset: { value: () => spy.mockReset() },
-        argsFor: { value: (index) => spy.mock.calls.at(index) },
-    });
-
-    return spy;
-}
-
 // expose so we don't need to import `expect` in every test file
 globalThis.expect = chai.expect;
-globalThis.spyOn = (object, prop) => jasmineSpyAdapter(spyOn(object, prop));
-globalThis.jasmine = {
-    any: expect.any,
-    arrayWithExactContents: () => {
-        throw new Error('TODO: jasmine.arrayWithExactContents');
-    },
-    createSpy: (name, impl) => jasmineSpyAdapter(fn(impl)),
-    objectContaining: expect.objectContaining,
-};
 
 /**
  * `@web/test-runner-mocha`'s autorun.js file inlines its own copy of mocha, and there's no direct

@@ -1,6 +1,7 @@
 import { createElement } from 'lwc';
 import Light from 'x/light';
 import Shadow from 'x/shadow';
+import { jasmine } from '../../../helpers/jasmine.js';
 import { nonStandardAriaProperties } from '../../../helpers/aria.js';
 import {
     attachReportingControlDispatcher,

@@ -2,6 +2,7 @@ import { createElement } from 'lwc';
 
 import AriaContainer from 'x/ariaContainer';
 import Valid from 'x/valid';
+import { jasmine } from '../../../helpers/jasmine.js';
 import {
     attachReportingControlDispatcher,
     detachReportingControlDispatcher,

@@ -1,4 +1,5 @@
 import { registerTemplate, freezeTemplate, setFeatureFlagForTest } from 'lwc';
+import { jasmine } from '../../../helpers/jasmine.js';
 
 import {
     attachReportingControlDispatcher,

@@ -7,6 +7,7 @@ import PublicPropertiesInheritance from 'x/publicPropertiesInheritance';
 import PublicMethodsInheritance from 'x/publicMethodsInheritance';
 import PrivateAccessors from 'x/privateAccessors';
 import HtmlElementProps from 'x/htmlElementProps';
+import { jasmine } from '../../../helpers/jasmine.js';
 import { ariaProperties } from '../../../helpers/aria.js';
 
 function testInvalidComponentConstructor(name, ctor) {

@@ -1,5 +1,6 @@
 import { createElement, isNodeFromTemplate } from 'lwc';
 import Test from 'x/test';
+import { jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 
 function testNonNodes(type, obj) {
     it(`should return false if the passed object if a ${type}`, () => {

@@ -1,5 +1,6 @@
 import { createElement } from 'lwc';
 import XInnerHtml from 'x/innerHtml';
+import { jasmine } from '../../../helpers/jasmine.js';
 import { getHooks, setHooks } from '../../../helpers/hooks.js';
 
 const ACTUAL_CONTENT = 'Hello <b>World</b>';

@@ -5,6 +5,7 @@ import Test from 'x/test';
 import DisconnectedCallbackThrow from 'x/disconnectedCallbackThrow';
 import DualTemplate from 'x/dualTemplate';
 import ExplicitRender from 'x/explicitRender';
+import { jasmine } from '../../../helpers/jasmine.js';
 import { customElementCallbackReactionErrorListener } from '../../../helpers/utils.js';
 
 function testDisconnectSlot(name, fn) {

@@ -3,6 +3,7 @@ import { createElement, setFeatureFlagForTest } from 'lwc';
 import Component from 'x/component';
 import Parent from 'x/parent';
 import LogsWhenConnected from 'x/logsWhenConnected';
+import { jasmine, jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 import {
     attachReportingControlDispatcher,
     detachReportingControlDispatcher,

@@ -1,6 +1,7 @@
 import { createElement } from 'lwc';
 import { installCustomContext, setCustomContext } from 'x/simpleProvider';
 import Consumer from 'x/simpleConsumer';
+import { jasmine } from '../../helpers/jasmine.js';
 
 describe('Simple Custom Context Provider', () => {
     it('should be install-able on any dom element', function () {

@@ -3,6 +3,7 @@ import { createElement, setFeatureFlagForTest } from 'lwc';
 import LockerIntegration from 'x/lockerIntegration';
 import LockerLiveComponent from 'x/lockerLiveComponent';
 import LockerHooks, { hooks } from 'x/lockerHooks';
+import { jasmine, jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 beforeEach(() => {
     setFeatureFlagForTest('LEGACY_LOCKER_ENABLED', true);
 });

@@ -1,5 +1,6 @@
 import { createElement } from 'lwc';
 import MixedSlotParent from 'x/mixedSlotParent';
+import { jasmineSpyOn as spyOn } from '../../../../helpers/jasmine.js';
 import { USE_COMMENTS_FOR_FRAGMENT_BOOKENDS } from '../../../../helpers/constants.js';
 
 const vFragBookend = USE_COMMENTS_FOR_FRAGMENT_BOOKENDS ? '<!---->' : '';

@@ -11,6 +11,7 @@ import RerenderLoop from 'x/rerenderLoop';
 import PublicProp from 'x/publicProp';
 import ComputedKey from 'x/computedKey';
 import ValueEvaluationThrows from 'x/ValueEvaluationThrows';
+import { jasmine } from '../../helpers/jasmine.js';
 import { spyConsole } from '../../helpers/console.js';
 import { catchUnhandledRejectionsAndErrors } from '../../helpers/utils.js';
 

@@ -1,5 +1,6 @@
 import { createElement } from 'lwc';
 import Parent from 'x/parent';
+import { jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 
 describe('vdom removes component while it is already disconnected', () => {
     let spy;

@@ -1,5 +1,6 @@
 import { createElement } from 'lwc';
 import Test from 'x/test';
+import { jasmine } from '../../../helpers/jasmine.js';
 
 describe('event.composedPath() of event dispatched from closed shadow root', () => {
     it('should have shadowed elements when invoked inside the shadow root', () => {

@@ -3,6 +3,7 @@ import { createElement } from 'lwc';
 import Component from 'x/component';
 import Parent from 'x/parent';
 import Light from 'x/light';
+import { jasmine } from '../../../helpers/jasmine.js';
 import {
     attachReportingControlDispatcher,
     detachReportingControlDispatcher,

@@ -4,6 +4,7 @@ import Any from 'x/any';
 import Reset from 'x/reset';
 import None from 'x/none';
 import NativeOnly from 'x/native';
+import { jasmine } from '../../../helpers/jasmine.js';
 import {
     attachReportingControlDispatcher,
     detachReportingControlDispatcher,

@@ -1,6 +1,7 @@
 import { createElement } from 'lwc';
 
 import Component from 'x/component';
+import { jasmine } from '../../../helpers/jasmine.js';
 import {
     ariaPropertiesMapping,
     nonPolyfilledAriaProperties,

@@ -1,6 +1,7 @@
 import { createElement } from 'lwc';
 import XTest from 'x/test';
 import XWithLwcDomManual from 'x/withLwcDomManual';
+import { jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 
 describe('should not provide access to elements inside shadow tree', () => {
     beforeEach(() => {

@@ -2,6 +2,7 @@ import { createElement } from 'lwc';
 import Parent from 'x/parent';
 import Child from 'x/child';
 import GetterThrows from 'x/getterThrows';
+import { jasmine, jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 
 const arr = jasmine.arrayWithExactContents;
 // `jasmine.objectContaining` is long, but the method can't be detached/aliased, ergo wrapper

@@ -1,5 +1,6 @@
 import { createElement } from 'lwc';
 import Component from 'x/component';
+import { jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 
 let spy;
 

@@ -1,6 +1,7 @@
 import { createElement } from 'lwc';
 import Inner from 'x/inner';
 import Outer from 'x/outer';
+import { jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 import { extractDataIds } from '../../../helpers/utils.js';
 
 beforeAll(() => {

@@ -1,6 +1,7 @@
 import { createElement, setFeatureFlagForTest } from 'lwc';
 import Component from 'x/component';
 import Scoping from 'x/scoping';
+import { jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 import { catchUnhandledRejectionsAndErrors } from '../../../helpers/utils.js';
 
 let caughtError;

@@ -3,6 +3,7 @@ import { createElement, LightningElement, registerTemplate, registerComponent }
 import Component from 'x/component';
 import ComponentWithProp from 'x/componentWithProp';
 import ComponentWithTemplateAndStylesheet from 'x/componentWithTemplateAndStylesheet';
+import { jasmine } from '../../../helpers/jasmine.js';
 import {
     attachReportingControlDispatcher,
     detachReportingControlDispatcher,

@@ -4,6 +4,7 @@ import Slotted from 'x/slotted';
 import Nested from 'x/nested';
 import NestedFallback from 'x/nestedFallback';
 import TestWithDiv from 'x/testWithDiv';
+import { jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 
 describe('Element.querySelector', () => {
     it('should return null if no Element match', () => {

@@ -1,6 +1,7 @@
 import { createElement } from 'lwc';
 
 import Container from 'x/container';
+import { jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 
 describe('Event.target', () => {
     let globalListener = () => {};

@@ -1,5 +1,6 @@
 import { createElement } from 'lwc';
 import Container from 'x/container';
+import { jasmine } from '../../../helpers/jasmine.js';
 import { extractDataIds } from '../../../helpers/utils.js';
 
 function createShadowTree(parentNode) {

@@ -1,5 +1,6 @@
 import { createElement } from 'lwc';
 import Container from 'x/container';
+import { jasmine } from '../../../helpers/jasmine.js';
 import { extractDataIds } from '../../../helpers/utils.js';
 
 function createShadowTree(parentNode) {

@@ -3,6 +3,7 @@ import XParent from 'x/parent';
 import XSlottedChild from 'x/slottedChild';
 import XNestedSlotContainer from 'x/nestedSlotContainer';
 import XTemplateMutations from 'x/templateMutations';
+import { jasmine } from '../../../helpers/jasmine.js';
 
 const observerConfig = { childList: true, subtree: true };
 

@@ -6,6 +6,7 @@ import WithLwcDomManualNested from 'x/withLwcDomManualNested';
 import WithLwcDomManual from 'x/withLwcDomManual';
 import WithoutLwcDomManual from 'x/withoutLwcDomManual';
 import Text from 'x/text';
+import { jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 
 const composedTrueConfig = { composed: true };
 describe('Node.getRootNode', () => {

@@ -11,6 +11,7 @@ import Throws from 'x/throws';
 // Note for testing purposes the signal implementation uses LWC module resolution to simplify things.
 // In production the signal will come from a 3rd party library.
 import { Signal } from 'x/signal';
+import { jasmine } from '../../../helpers/jasmine.js';
 
 describe('signal protocol', () => {
     beforeAll(() => {

@@ -1,5 +1,6 @@
 import { createElement } from 'lwc';
 import Test from 'x/test';
+import { jasmine, jasmineSpyOn as spyOn } from '../../helpers/jasmine.js';
 import { getHooks, setHooks } from '../../helpers/hooks.js';
 
 function setSanitizeHtmlContentHookForTest(impl) {

@@ -23,6 +23,7 @@ import Text from 'x/text';
 import TableWithExpression from 'x/tableWithExpressions';
 import TextWithoutPreserveComments from 'x/textWithoutPreserveComments';
 import TextWithPreserveComments from 'x/textWithPreserveComments';
+import { jasmine } from '../../helpers/jasmine.js';
 import { LOWERCASE_SCOPE_TOKENS } from '../../helpers/constants.js';
 import { extractDataIds } from '../../helpers/utils.js';
 

@@ -2,6 +2,7 @@ import { createElement } from 'lwc';
 
 import Container from 'x/container';
 import ParentSpecialized from 'x/parentSpecialized';
+import { jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 
 /*
  <div>

@@ -3,6 +3,7 @@ import { createElement } from 'lwc';
 import withLwcDomManual from 'x/withLwcDomManual';
 import withoutLwcDomManual from 'x/withoutLwcDomManual';
 import SvgWithLwcDomManual from 'x/svgWithLwcDomManual';
+import { jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
 
 function waitForStyleToBeApplied() {
     return Promise.resolve();

@@ -1,6 +1,7 @@
 import { createElement } from 'lwc';
 import Shadow from 'x/shadow';
 import Light from 'x/light';
+import { jasmine } from '../../../helpers/jasmine.js';
 import {
     attachReportingControlDispatcher,
     detachReportingControlDispatcher,
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ import { createElement } from 'lwc'; @@
     import Container from 'x/container';
     import ParentSpecialized from 'x/parentSpecialized';
+    import { jasmineSpyOn as spyOn } from '../../../helpers/jasmine.js';
     /*
      <div>
@@ Expand Down @@