-
Notifications
You must be signed in to change notification settings - Fork 439
test(wtr): enable custom elements registry tests @W-19097891 #5509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
8c7ed79
test(wtr): update tests to use relative path to utils
wjhsf e2f88d5
test(wtr): revert removing TestUtils
wjhsf 81275d0
test(wtr): remove useless describe
wjhsf 39533d3
test(wtr): replace IIFE script with module import
wjhsf 33e58c8
test(wtr): clean up SSR execution script
wjhsf d0b8003
test(wtr): always use DISABLE_SYNTHETIC
wjhsf 976c002
test(wtr): enable all hydration tests
wjhsf 8d39505
Merge branch 'master' into wjh/wtr-hyd
wjhsf c66afad
test(wtr): remove side effect from signals helper
wjhsf f1c50b0
test(wtr): import directly from file, not from barrel exporter
wjhsf 7a73bf0
test(wtr): change bulk export statement to individual exports
wjhsf 9b7b21b
test(wtr): remove unnecessary aria re-export
wjhsf 9deaca2
test(wtr): fix a few more ARIA util imports
wjhsf 1cf1275
chore: move comment for nicer aesthetic
wjhsf 7fc137c
test(wtr): remove unused option
wjhsf ae937cc
test(wtr): fix another ARIA util import
wjhsf 9250dd5
test(wtr): import directly from hooks file rather than utils
wjhsf d4280e8
test(wtr): import directly from signals file rather than utils
wjhsf bbffbf3
test(wtr): import directly from console helper rather than utils
wjhsf 1ef88ed
test(wtr): import directly from constants helper rather than utils
wjhsf 02f8ed1
test(wtr): only import what is needed from LWC
wjhsf 7a5260a
test(wtr): split lwc:dynamic load helpers into separate file
wjhsf 1a08a62
test(wtr): avoid relying on global LWC
wjhsf f14c829
Merge branch 'master' into wjh/wtr-smaller-utils
wjhsf 289deeb
Merge branch 'master' into wjh/wtr-smaller-utils
wjhsf b97f783
test(wtr): remove unnecessary wrapping of hydration test config
wjhsf 3cdb65c
test(wtr): remove test-utils logic from resolveImport
wjhsf 7009a26
test(wtr): move plugin from shared config to only config that uses it
wjhsf 19c1090
test(wtr): remove useless guid
wjhsf 5e75329
test(wtr): remove unnecessary test-utils global
wjhsf 497bfa8
test(wtr): clean up component definition
wjhsf 8ff59c5
test(wtr): change component in test from IIFE to import
wjhsf 885ce57
test(wtr): shift logic out of wrapper into static test runner file
wjhsf aa47c49
test(wtr): make test setup/teardown more idiomatic
wjhsf 6185811
test(wtr): clean up module compilation
wjhsf ec0186f
chore(wtr): make dependency on @vitest/spy explicit
wjhsf 3463450
test(wtr): remove console suppression
wjhsf 7c0eb0a
test(wtr): clean up names and comments
wjhsf d91c8aa
Merge branch 'master' into wjh/wtr-clean-hydration
wjhsf 371032d
Merge branch 'master' into wjh/wtr-clean-hydration
wjhsf c47a44d
test(wtr): move and rename file
wjhsf 639f754
Merge branch 'master' into wjh/wtr-clean-hydration
wjhsf c21a895
test(wtr): remove usage of global TestUtils from hydration tests
wjhsf d041a23
test(wtr): remove LWC import from utils
wjhsf cb6213c
test(wtr): remove unused external deps
wjhsf 76efacb
test(wtr): use imports instead of jasmine globals
wjhsf e86cbc4
chore(eslint): remove unused rule config
wjhsf 136f47b
fix: attribute cte syntax in integration tests
jhefferman-sfdc 6e31af9
test(wtr): fix case in import
wjhsf 9805b58
test(wtr): re-enable tests that used to fail in CI
wjhsf 67f727b
test(wtr): enable browser logs
wjhsf 370da4c
Merge remote-tracking branch 'origin/jhefferman/fix-cte-integration-t…
wjhsf 22822f7
test(wtr): name plugins
wjhsf 654aef7
test(wtr): rename variables and document functions for clarity
wjhsf bc09749
test(wtr): convert promise chains to async/await
wjhsf 99d6b27
Merge branch 'master' into wjh/wtr-spam
wjhsf c494abe
test(wtr): load code from known url, rather than sniffing script tag
wjhsf 02ca871
test(wtr): convert LWC from iife to fake cjs
wjhsf 85610ff
test(wtr): remove unnecessary wrapping
wjhsf 96fa673
Merge branch 'master' into wjh/wtr-spam
wjhsf bcba665
test(wtr): data can be data, not a function
wjhsf b79d66b
test(wtr): replace `evaluate` with functions that require less wrapping
wjhsf 3437c71
test(wtr): only fetch scripts once
wjhsf 23491ec
test(wtr): john was here
wjhsf 947612f
test(wtr): add line breaks and vars for clarity
wjhsf 9fa8504
test(wtr): rename variable
wjhsf 97ee6e9
test(wtr): fix param pass through
wjhsf 159d046
test(wtr): more cleanup
wjhsf 2e8abcf
test(wtr): remove outdated comment
wjhsf d9eda1d
test(wtr): avoid shadowing global var
wjhsf 43818d5
test(wtr): enable custom element registry tests
wjhsf ec5293d
Merge branch 'master' into wjh/wtr-spam
wjhsf 225da98
test(wtr): hoist function definition
wjhsf 3d51c59
Apply suggestion from @jmsjtu
wjhsf 076b8ad
test(wtr): clarify commonjs workarounds
wjhsf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wjhsf does this mean that
@web/dev-serverwill handle appending the../for us?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/__wds-outside-root__/is a magic path provided by@web/dev-serveras a workaround for the fact that you can't../out of a web root (in our case,packages@/lwc/integration-not-karma).When we serve pages with code like
import * as LWC from 'lwc',@web/dev-servertransforms that import before serving because node-style imports don't work in the browser. First it resolves the path, in this case to../lwc/index.js. But that import wouldn't work, so it gets transformed again to/__wds-outside-root__/1/lwc/index.js. And then when the browser requests that file, the server knows where to look.That's fine and dandy for regular imports, but sometimes we do weird hacky nonsense that needs the same transformation, but
@web/dev-serverdoesn't do it for us. So we do it ourselves.