-
Notifications
You must be signed in to change notification settings - Fork 11
iam: getInlinePolicyDetails API(GCP) #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
iam: getInlinePolicyDetails API(GCP) #163
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (70.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
============================================
- Coverage 83.14% 83.13% -0.02%
- Complexity 91 94 +3
============================================
Files 150 150
Lines 8134 8139 +5
Branches 945 947 +2
============================================
+ Hits 6763 6766 +3
- Misses 923 924 +1
- Partials 448 449 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| * | ||
| * @param identityName the name of the identity | ||
| * @param policyName the name of the policy | ||
| * @param policyName the name of the policy. This parameter is optional and subject to cloud semantics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update our AwsIam for this function signature change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no AwsIam as of now, but yes when it's created this should be the signature.
| * @return the policy document details as a string | ||
| */ | ||
| public String getInlinePolicyDetails(String identityName, String policyName, String tenantId, String region) { | ||
| public String getInlinePolicyDetails(String identityName, String policyName, String roleName, String tenantId, String region) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for adding this roleName? Is it for aws and ali?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for GCP. GCP APIs need roleName and AWS APIs need tenantId.
11a2cbd to
87e57f7
Compare
87e57f7 to
deeffb4
Compare
Summary
< Provide a brief description of the changes in this PR >
Some conventions to follow
docstore:for document store module,blobstorefor Blob Store moduletest:perf: