Skip to content

Conversation

@Yaminik1996
Copy link
Contributor

Summary

< Provide a brief description of the changes in this PR >

Some conventions to follow

  1. add the module name as a prefix
    • for example: add a prefix: docstore: for document store module, blobstore for Blob Store module
  2. for a test only PR, add test:
  3. for a perf improvement only PR, add perf:
  4. for a refactoring only PR, add "refactor:"

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.13%. Comparing base (3610b57) to head (11a2cbd).

Files with missing lines Patch % Lines
...ava/com/salesforce/multicloudj/iam/gcp/GcpIam.java 62.50% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (70.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #163      +/-   ##
============================================
- Coverage     83.14%   83.13%   -0.02%     
- Complexity       91       94       +3     
============================================
  Files           150      150              
  Lines          8134     8139       +5     
  Branches        945      947       +2     
============================================
+ Hits           6763     6766       +3     
- Misses          923      924       +1     
- Partials        448      449       +1     
Flag Coverage Δ
unittests 83.13% <70.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yaminik1996 Yaminik1996 marked this pull request as ready for review November 25, 2025 19:04
*
* @param identityName the name of the identity
* @param policyName the name of the policy
* @param policyName the name of the policy. This parameter is optional and subject to cloud semantics.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update our AwsIam for this function signature change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no AwsIam as of now, but yes when it's created this should be the signature.

* @return the policy document details as a string
*/
public String getInlinePolicyDetails(String identityName, String policyName, String tenantId, String region) {
public String getInlinePolicyDetails(String identityName, String policyName, String roleName, String tenantId, String region) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for adding this roleName? Is it for aws and ali?

Copy link
Contributor Author

@Yaminik1996 Yaminik1996 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for GCP. GCP APIs need roleName and AWS APIs need tenantId.

@Yaminik1996 Yaminik1996 force-pushed the W-20111602/iamPolicyAPIsGCP branch 2 times, most recently from 11a2cbd to 87e57f7 Compare December 11, 2025 22:46
@Yaminik1996 Yaminik1996 force-pushed the W-20111602/iamPolicyAPIsGCP branch from 87e57f7 to deeffb4 Compare December 12, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants