blobstore: make blob store autocloseable throughout#194
blobstore: make blob store autocloseable throughout#194sandeepvinayak merged 4 commits intosalesforce:mainfrom
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
============================================
- Coverage 83.62% 83.14% -0.49%
Complexity 91 91
============================================
Files 150 150
Lines 8087 8134 +47
Branches 944 945 +1
============================================
Hits 6763 6763
- Misses 876 923 +47
Partials 448 448
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| * This class serves the purpose of providing common (i.e. substrate-agnostic) functionality. | ||
| */ | ||
| public abstract class AbstractBlobClient<T extends AbstractBlobClient<T>> implements Provider, SdkService { | ||
| public abstract class AbstractBlobClient<T extends AbstractBlobClient<T>> implements Provider, SdkService, AutoCloseable { |
There was a problem hiding this comment.
Do we need a default close method in AbstractBlobClient and AbstractBlobStore?
@Override public void close() { }
There was a problem hiding this comment.
not really because we want to force the providers to implement the close
Co-authored-by: Lihao Liu <47010345+LihaoLiuXs@users.noreply.github.com>
Summary
< Provide a brief description of the changes in this PR >
Some conventions to follow
docstore:for document store module,blobstorefor Blob Store moduletest:perf: