Skip to content

blobstore: make blob store autocloseable throughout#194

Merged
sandeepvinayak merged 4 commits intosalesforce:mainfrom
sandeepvinayak:spal/addclose
Dec 6, 2025
Merged

blobstore: make blob store autocloseable throughout#194
sandeepvinayak merged 4 commits intosalesforce:mainfrom
sandeepvinayak:spal/addclose

Conversation

@sandeepvinayak
Copy link
Contributor

Summary

< Provide a brief description of the changes in this PR >

Some conventions to follow

  1. add the module name as a prefix
    • for example: add a prefix: docstore: for document store module, blobstore for Blob Store module
  2. for a test only PR, add test:
  3. for a perf improvement only PR, add perf:
  4. for a refactoring only PR, add "refactor:"

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.14%. Comparing base (3953892) to head (c266a48).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...salesforce/multicloudj/blob/gcp/GcpBlobClient.java 0.00% 6 Missing ⚠️
.../salesforce/multicloudj/blob/gcp/GcpBlobStore.java 0.00% 6 Missing ⚠️
.../multicloudj/blob/gcp/async/GcpAsyncBlobStore.java 0.00% 6 Missing ⚠️
.../multicloudj/blob/aws/async/AwsAsyncBlobStore.java 0.00% 5 Missing ⚠️
...salesforce/multicloudj/blob/ali/AliBlobClient.java 0.00% 3 Missing ⚠️
.../salesforce/multicloudj/blob/ali/AliBlobStore.java 0.00% 3 Missing ⚠️
...salesforce/multicloudj/blob/aws/AwsBlobClient.java 0.00% 3 Missing ⚠️
.../salesforce/multicloudj/blob/aws/AwsBlobStore.java 0.00% 3 Missing ⚠️
...lticloudj/blob/async/client/AsyncBucketClient.java 0.00% 3 Missing ⚠️
...cloudj/blob/async/driver/BlobStoreAsyncBridge.java 0.00% 3 Missing ⚠️
... and 2 more

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #194      +/-   ##
============================================
- Coverage     83.62%   83.14%   -0.49%     
  Complexity       91       91              
============================================
  Files           150      150              
  Lines          8087     8134      +47     
  Branches        944      945       +1     
============================================
  Hits           6763     6763              
- Misses          876      923      +47     
  Partials        448      448              
Flag Coverage Δ
unittests 83.14% <0.00%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* This class serves the purpose of providing common (i.e. substrate-agnostic) functionality.
*/
public abstract class AbstractBlobClient<T extends AbstractBlobClient<T>> implements Provider, SdkService {
public abstract class AbstractBlobClient<T extends AbstractBlobClient<T>> implements Provider, SdkService, AutoCloseable {
Copy link
Collaborator

@LihaoLiuXs LihaoLiuXs Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a default close method in AbstractBlobClient and AbstractBlobStore?

@Override public void close() { }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really because we want to force the providers to implement the close

@sandeepvinayak sandeepvinayak merged commit 3610b57 into salesforce:main Dec 6, 2025
5 checks passed
Yaminik1996 pushed a commit to Yaminik1996/multicloudj that referenced this pull request Dec 17, 2025
Co-authored-by: Lihao Liu <47010345+LihaoLiuXs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants