blobstore: Implement the DoesBucketExist for Blob#195
blobstore: Implement the DoesBucketExist for Blob#195sandeepvinayak merged 9 commits intosalesforce:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
============================================
+ Coverage 83.16% 83.18% +0.01%
Complexity 91 91
============================================
Files 150 150
Lines 8145 8182 +37
Branches 944 948 +4
============================================
+ Hits 6774 6806 +32
- Misses 923 926 +3
- Partials 448 450 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Patch test coverage increased to 86%. |
| { | ||
| "id" : "53ad5ca5-5655-401b-a5e2-0dc2e553d25c", | ||
| "name" : "storage_v1_b_substrate-sdk-gcp-poc1-test-bucket", | ||
| "request" : { | ||
| "url" : "/storage/v1/b/substrate-sdk-gcp-poc1-test-bucket?projection=full", | ||
| "method" : "GET" | ||
| }, | ||
| "response" : { | ||
| "status" : 200, |
There was a problem hiding this comment.
seems like the test ran twice in recording mode for gcp, there are duplicate recordings in the PR
There was a problem hiding this comment.
Good catch! I updated the recording files for gcp.
Summary
Conformance tested for aws and gcp.
< Provide a brief description of the changes in this PR >
Some conventions to follow
docstore:for document store module,blobstorefor Blob Store moduletest:perf: