test: remove timeouts for pubsub test run #203
Closed
+485
−511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
=========================================
Coverage 83.18% 83.18%
Complexity 91 91
=========================================
Files 150 150
Lines 8182 8182
Branches 948 948
=========================================
Hits 6806 6806
Misses 926 926
Partials 450 450
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LihaoLiuXs
reviewed
Dec 15, 2025
| long timeoutSeconds = isRecording ? 120 : 60; // Increased timeout for integration tests | ||
| long deadline = System.nanoTime() + TimeUnit.SECONDS.toNanos(timeoutSeconds); | ||
|
|
||
| System.out.println("Starting to collect " + toSend.size() + " messages with timeout: " + timeoutSeconds + "s"); |
Collaborator
There was a problem hiding this comment.
Let’s remove this System.out.println from the code and use the logger instead.
LihaoLiuXs
reviewed
Dec 15, 2025
| Message r = subscription.receive(); | ||
| if (r != null && r.getAckID() != null) { | ||
| ackIDs.add(r.getAckID()); | ||
| System.out.println("Received message " + ackIDs.size() + "/" + toSend.size() + |
LihaoLiuXs
reviewed
Dec 15, 2025
| System.out.println("Received message " + ackIDs.size() + "/" + toSend.size() + | ||
| " with AckID: " + r.getAckID()); | ||
| } else { | ||
| System.out.println("Received null message, waiting..."); |
Yaminik1996
force-pushed
the
W-20494137/pubsubFlakyTest
branch
from
89f4306 to
f0f05e7
Compare
LihaoLiuXs
approved these changes
Dec 15, 2025
Yaminik1996
force-pushed
the
W-20494137/pubsubFlakyTest
branch
from
f0f05e7 to
89f4306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing explicit timeouts in pubsub tests because they make them flaky. Sometimes the test is almost over but the timeout aborts it resulting in a failure. The test performance has also been improved in this PR by removing conditional and unconditional sleep statements.
Some conventions to follow
docstore:for document store module,blobstorefor Blob Store moduletest:perf: