test: enable GCP blobstore conformance tests by Yaminik1996 · Pull Request #232 · salesforce/multicloudj

Yaminik1996 · 2025-12-23T21:43:37Z

Summary

Enables a bunch of blob store conformance tests for the GCP substrate. The remaining tests will require some special transformer logic or changes to core logic. So that's a bigger discussion and will be addressed in a follow-up work item.

Some conventions to follow

add the module name as a prefix
- for example: add a prefix: docstore: for document store module, blobstore for Blob Store module
for a test only PR, add test:
for a perf improvement only PR, add perf:
for a refactoring only PR, add "refactor:"

codecov-commenter · 2025-12-23T21:49:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.64%. Comparing base (1f4b7d0) to head (dd8ee89).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #232      +/-   ##
============================================
+ Coverage     82.63%   82.64%   +0.01%     
  Complexity      125      125              
============================================
  Files           152      152              
  Lines          8590     8590              
  Branches       1042     1042              
============================================
+ Hits           7098     7099       +1     
+ Misses         1001     1000       -1     
  Partials        491      491

Flag	Coverage Δ
unittests	`82.64% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

LihaoLiuXs · 2025-12-26T21:46:44Z

blob/blob-gcp/src/test/resources/mappings/delete-plk6u8nyll.json

We already have many recorded files under the GCP conformance tests. Could you please confirm that this PR does not introduce any duplicate record files?

sandeepvinayak · 2026-01-09T00:57:44Z

blob/blob-client/src/test/java/com/salesforce/multicloudj/blob/client/AbstractBlobStoreIT.java

+            runOperationsThatShouldNotFail("testInvalidCredentials", bucketClient);
+        }


nit:tabs added by AI?

The initial spacing was misplaced. The alignment is correct now.

sandeepvinayak · 2026-01-09T19:48:17Z

blob/blob-client/src/test/java/com/salesforce/multicloudj/blob/client/AbstractBlobStoreIT.java

+        default List<String> getWiremockExtensions() {
+            return Collections.emptyList();
+        }


let's remove the unnecessary code

iamabhilaksh · 2026-01-12T19:59:55Z

blob/blob-gcp/src/test/java/com/salesforce/multicloudj/blob/gcp/GcpBlobStoreIT.java


 import java.io.IOException;
 import java.net.URI;
+import java.util.List;


Is this import required ?

Removed, thanks for catching

iamabhilaksh · 2026-01-12T20:02:03Z

blob/blob-client/src/test/java/com/salesforce/multicloudj/blob/client/AbstractBlobStoreIT.java

 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
+import java.util.Collections;


Is this import required ?

Removed, thanks for catching

iamabhilaksh · 2026-01-12T20:22:50Z

Referring to the latest AbstractBlobStoreIT.java file, there are a total of 12 different places from where you need to remove this to enable GCP conformance tests.

Search phrase used : Assumptions.assumeFalse(GCP_PROVIDER_ID.equals(harness.getProviderId()));
In your changes AbstractBlobStoreIT.java I can still see some tests for which this line has not been removed.

==> Are we not enabling GCP blobstore conformance tests for all of them ?

iamabhilaksh · 2026-01-13T17:09:37Z

Referring to the latest AbstractBlobStoreIT.java file, there are a total of 12 different places from where you need to remove this to enable GCP conformance tests.

Search phrase used : Assumptions.assumeFalse(GCP_PROVIDER_ID.equals(harness.getProviderId())); In your changes AbstractBlobStoreIT.java I can still see some tests for which this line has not been removed.

==> Are we not enabling GCP blobstore conformance tests for all of them ?

PR description has been updated with the reasoning.

… testUploadWithKmsKey_happyPath, testUploadWithKmsKey_emptyKmsKeyId, testUploadWithKmsKey_nullKmsKeyId, testRangedReadWithKmsKey, testVersionedCopyFrom

salesforce-cla bot added the cla:signed label Dec 23, 2025

LihaoLiuXs reviewed Dec 26, 2025

View reviewed changes

Yaminik1996 force-pushed the W-20028687/gcpBlobStoreConformanceTestsRemaining branch from 7300ce3 to 3b9b243 Compare December 29, 2025 20:11

LihaoLiuXs approved these changes Dec 29, 2025

View reviewed changes

Yaminik1996 force-pushed the W-20028687/gcpBlobStoreConformanceTestsRemaining branch 4 times, most recently from 5db5813 to 6063319 Compare January 8, 2026 22:57

sandeepvinayak reviewed Jan 9, 2026

View reviewed changes

Yaminik1996 force-pushed the W-20028687/gcpBlobStoreConformanceTestsRemaining branch 4 times, most recently from 163bae2 to 3d8d71a Compare January 9, 2026 19:26

sandeepvinayak reviewed Jan 9, 2026

View reviewed changes

Yaminik1996 force-pushed the W-20028687/gcpBlobStoreConformanceTestsRemaining branch 3 times, most recently from 403a608 to de6cb0d Compare January 12, 2026 16:34

iamabhilaksh reviewed Jan 12, 2026

View reviewed changes

iamabhilaksh approved these changes Jan 13, 2026

View reviewed changes

Yaminik1996 force-pushed the W-20028687/gcpBlobStoreConformanceTestsRemaining branch 2 times, most recently from e3c085e to 756a0b0 Compare January 15, 2026 19:16

sandeepvinayak approved these changes Jan 15, 2026

View reviewed changes

test: Enable GCP blob store conformance tests testDownloadWithKmsKey,…

dd8ee89

… testUploadWithKmsKey_happyPath, testUploadWithKmsKey_emptyKmsKeyId, testUploadWithKmsKey_nullKmsKeyId, testRangedReadWithKmsKey, testVersionedCopyFrom

Yaminik1996 force-pushed the W-20028687/gcpBlobStoreConformanceTestsRemaining branch from 756a0b0 to dd8ee89 Compare January 15, 2026 23:01

sandeepvinayak enabled auto-merge (squash) January 15, 2026 23:06

sandeepvinayak merged commit 89ecbf2 into salesforce:main Jan 15, 2026
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: enable GCP blobstore conformance tests#232

test: enable GCP blobstore conformance tests#232
sandeepvinayak merged 1 commit intosalesforce:mainfrom
Yaminik1996:W-20028687/gcpBlobStoreConformanceTestsRemaining

Yaminik1996 commented Dec 23, 2025 •

edited

Loading

Uh oh!

codecov-commenter commented Dec 23, 2025 •

edited

Loading

Uh oh!

LihaoLiuXs Dec 26, 2025

Uh oh!

sandeepvinayak Jan 9, 2026

Uh oh!

Yaminik1996 Jan 9, 2026

Uh oh!

sandeepvinayak Jan 9, 2026

Uh oh!

iamabhilaksh Jan 12, 2026

Uh oh!

Yaminik1996 Jan 13, 2026

Uh oh!

iamabhilaksh Jan 12, 2026

Uh oh!

Yaminik1996 Jan 13, 2026

Uh oh!

iamabhilaksh commented Jan 12, 2026

Uh oh!

iamabhilaksh commented Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		runOperationsThatShouldNotFail("testInvalidCredentials", bucketClient);
		}

Conversation

Yaminik1996 commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Some conventions to follow

Uh oh!

codecov-commenter commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamabhilaksh commented Jan 12, 2026

Uh oh!

iamabhilaksh commented Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Yaminik1996 commented Dec 23, 2025 •

edited

Loading

codecov-commenter commented Dec 23, 2025 •

edited

Loading