sts: support access boundary in aws and gcp sts #240
sts: support access boundary in aws and gcp sts #240sandeepvinayak merged 6 commits intosalesforce:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
============================================
- Coverage 83.20% 83.15% -0.06%
Complexity 94 94
============================================
Files 150 150
Lines 8256 8368 +112
Branches 967 990 +23
============================================
+ Hits 6869 6958 +89
- Misses 933 945 +12
- Partials 454 465 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sandeepvinayak
force-pushed
the
spal/sts-access-boundary
branch
2 times, most recently
from
46d1cd7 to
1e4c34a
Compare
sandeepvinayak
force-pushed
the
spal/sts-access-boundary
branch
from
1e4c34a to
6ed7f97
Compare
| */ | ||
| private String toJsonString(Map<String, Object> map) { | ||
| try { | ||
| return new ObjectMapper().writeValueAsString(map); |
There was a problem hiding this comment.
nit: should we use static initialised Constant ObjectMapper here ?
| * Maps MultiCloudJ storage actions to AWS S3 actions. | ||
| * Example: "storage:GetObject" -> "s3:GetObject" | ||
| */ | ||
| private String convertPermissionToAction(String permission) { |
There was a problem hiding this comment.
QQ:
- Can we expect non-storage related actions in
permissionstring going forward ? - Should we add a unsupported check for
permissionif it doesn't start withstorage:?
| * Example: "storage://my-bucket" -> "arn:aws:s3:::my-bucket/*" | ||
| */ | ||
| private String convertResourceToArn(String resource) { | ||
| String bucketName = resource.substring("storage://".length()); |
There was a problem hiding this comment.
Same as above: Should we strict prefix check "storage://" for resource string till we support other use cases ?
There was a problem hiding this comment.
very likely it won't be extended based on known use-cases. but I think it's good idea to add precondition until we add support, will add it.
4 participants
Summary
< Provide a brief description of the changes in this PR >
Some conventions to follow
docstore:for document store module,blobstorefor Blob Store moduletest:perf: