blob: onboard SymbolicLinks in AWS and GCP#328
blob: onboard SymbolicLinks in AWS and GCP#328roseyang62 wants to merge 10 commits intosalesforce:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
=========================================
Coverage 82.36% 82.37%
Complexity 625 625
=========================================
Files 191 191
Lines 11503 11506 +3
Branches 1525 1526 +1
=========================================
+ Hits 9475 9478 +3
Misses 1357 1357
Partials 671 671
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@roseyang62 |
roseyang62
force-pushed
the
blob/follow-symbolic-links
branch
from
9d9aae8 to
8791e5b
Compare
| Files.walk(tempDir) | ||
| .sorted((a, b) -> b.compareTo(a)) | ||
| .forEach( | ||
| path -> { | ||
| try { | ||
| Files.deleteIfExists(path); | ||
| } catch (IOException e) { | ||
| // Ignore cleanup errors | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
this is the unit test - what are we deleting ?
There was a problem hiding this comment.
likewise in other test - seems like a miss before as well.
There was a problem hiding this comment.
yea..it never touches the file system. There's no need to create real temp directories and also clean them up in these unit tests.
4 participants
Summary
E2E test: https://docs.google.com/document/d/120zAMeN8ycjsoiTZTOUo7QNK_5DtZLKU-2mJbdaCm9M/edit?tab=t.0
Some conventions to follow
docstore:for document store module,blobstorefor Blob Store moduletest:perf: