registry: update example to include AWS provider usage#329
Open
iamabhilaksh wants to merge 2 commits intosalesforce:mainfrom
Open
registry: update example to include AWS provider usage#329iamabhilaksh wants to merge 2 commits intosalesforce:mainfrom
iamabhilaksh wants to merge 2 commits intosalesforce:mainfrom
Conversation
Contributor
Author
sharatchandrag
approved these changes
Mar 5, 2026
sandeepvinayak
approved these changes
Mar 5, 2026
iamabhilaksh
force-pushed
the
registry/update-example-for-aws
branch
from
4b4e2a8 to
cd863b6
Compare
Add registry-aws dependency to examples/pom.xml. Update Main.java to use generic placeholder endpoints, add REGION constant, and pass withRegion() to the client builder to support running the example with AWS ECR. Made-with: Cursor
iamabhilaksh
force-pushed
the
registry/update-example-for-aws
branch
from
cd863b6 to
880f6d4
Compare
Made-with: Cursor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
============================================
- Coverage 82.36% 82.36% -0.01%
Complexity 625 625
============================================
Files 191 191
Lines 11503 11503
Branches 1525 1525
============================================
- Hits 9475 9474 -1
- Misses 1357 1358 +1
Partials 671 671
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registry: update example to include AWS provider usage
Updates the registry
Main.javaexample to support AWS ECR in addition to GCP.Changes
Main.java— addedREGIONconstant; replaced hardcoded GCP-specific endpoint and repository with generic placeholders; passedwithRegion()toContainerRegistryClientbuilder calls.examples/pom.xml— addedregistry-awsdependency.Note
This PR depends on the AWS registry implementation PR #324 being merged first.
Registry Demo Testing Details
Overview
Main.javainexamples/src/main/java/com/salesforce/multicloudj/registry/Main.javawas testedend-to-end for AWS ECR.
AWS Test Run
Inputs
DEFAULT_PROVIDERawsREGISTRY_ENDPOINThttps://654654370895.dkr.ecr.us-east-1.amazonaws.comREPOSITORYtest-registryTAGlatestREGIONus-east-1AWS credentials were supplied via environment variables:
AWS_ACCESS_KEY_IDAWS_SECRET_ACCESS_KEYAWS_SESSION_TOKENCommand
Console Output
Result: ✅ ALL SECTIONS PASSED