blob: add Content-Disposition override support for pre-signed URLs in AWS and GCP#331
Merged
sandeepvinayak merged 1 commit intosalesforce:mainfrom Mar 7, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
============================================
+ Coverage 81.97% 81.98% +0.01%
Complexity 520 520
============================================
Files 181 181
Lines 11112 11119 +7
Branches 1477 1480 +3
============================================
+ Hits 9109 9116 +7
Misses 1340 1340
Partials 663 663
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Please provide the real cloud testing scenario document for the pr |
sandeepvinayak
approved these changes
Mar 6, 2026
fdc1d3f to
9d1ec75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional contentDisposition field to
PresignedUrlRequestto allow consumers to override the Content-Disposition header in pre-signed download URLs.AWS E2E Test:https://docs.google.com/document/d/1a5JKPqnODjd6mKzAyqSjK8PlnxTvgp4BjExzYcrel00/edit?tab=t.0
For GCP: signUrl requires a SA private key for local signing. My OAuth credentials do not provide a private key, making it impossible to generate valid presigned URLs in test environments without a SA JSON key file.
Some conventions to follow
docstore:for document store module,blobstorefor Blob Store moduletest:perf: