Skip to content

blob: add Content-Disposition override support for pre-signed URLs in AWS and GCP#331

Merged
sandeepvinayak merged 1 commit intosalesforce:mainfrom
roseyang62:onboard-content-disposition
Mar 7, 2026
Merged

blob: add Content-Disposition override support for pre-signed URLs in AWS and GCP#331
sandeepvinayak merged 1 commit intosalesforce:mainfrom
roseyang62:onboard-content-disposition

Conversation

@roseyang62
Copy link
Contributor

@roseyang62 roseyang62 commented Mar 6, 2026

Summary

Add optional contentDisposition field to PresignedUrlRequest to allow consumers to override the Content-Disposition header in pre-signed download URLs.

AWS E2E Test:https://docs.google.com/document/d/1a5JKPqnODjd6mKzAyqSjK8PlnxTvgp4BjExzYcrel00/edit?tab=t.0

For GCP: signUrl requires a SA private key for local signing. My OAuth credentials do not provide a private key, making it impossible to generate valid presigned URLs in test environments without a SA JSON key file.

Some conventions to follow

  1. add the module name as a prefix
    • for example: add a prefix: docstore: for document store module, blobstore for Blob Store module
  2. for a test only PR, add test:
  3. for a perf improvement only PR, add perf:
  4. for a refactoring only PR, add "refactor:"

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.98%. Comparing base (1477146) to head (9d1ec75).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #331      +/-   ##
============================================
+ Coverage     81.97%   81.98%   +0.01%     
  Complexity      520      520              
============================================
  Files           181      181              
  Lines         11112    11119       +7     
  Branches       1477     1480       +3     
============================================
+ Hits           9109     9116       +7     
  Misses         1340     1340              
  Partials        663      663              
Flag Coverage Δ
unittests 81.98% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roseyang62 roseyang62 changed the title blob: add Content-Disposition override support for pre-signed URLs blob: add Content-Disposition override support for pre-signed URLs in AWS and GCP Mar 6, 2026
@roseyang62 roseyang62 marked this pull request as ready for review March 6, 2026 02:27
@sharatchandrag
Copy link
Contributor

Please provide the real cloud testing scenario document for the pr

@roseyang62 roseyang62 force-pushed the onboard-content-disposition branch from fdc1d3f to 9d1ec75 Compare March 6, 2026 22:45
@sandeepvinayak sandeepvinayak merged commit be14812 into salesforce:main Mar 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants