Skip to content

feat: @W-16299313 PoC iframe keepAlive#460

Draft
rwaldron wants to merge 1 commit intomainfrom
rwaldron/keepalive
Draft

feat: @W-16299313 PoC iframe keepAlive#460
rwaldron wants to merge 1 commit intomainfrom
rwaldron/keepalive

Conversation

@rwaldron
Copy link
Copy Markdown
Contributor

@rwaldron rwaldron commented Aug 2, 2024

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 2, 2024

Metric Coverage Percent Covered / Total
Statements 81.6% ( 856/1049 )
Branches 56.06% ( 199/355 )
Functions 73.87% ( 82/111 )
Lines 81.38% ( 826/1015 )
Total 73.23%

See detailed coverage

@rwaldron rwaldron force-pushed the rwaldron/keepalive branch from 8134aac to dcbe2db Compare August 5, 2024 19:18
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 5, 2024

Metric Coverage Percent Covered / Total
Statements 81.35% ( 842/1035 )
Branches 56% ( 196/350 )
Functions 73.87% ( 82/111 )
Lines 81.12% ( 812/1001 )
Total 73.09%

See detailed coverage


iframeStash = ReflectApply(ElementProtoAttachShadow, host, [
{ mode: 'closed' },
]) as ShadowRoot;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool 🎉 !

@jdalton
Copy link
Copy Markdown
Contributor

jdalton commented Nov 14, 2024

Love this approach. A large chunk of src/membrane.ts can be removed too:
https://github.com/salesforce/near-membrane/blob/v0.13.12/packages/near-membrane-base/src/membrane.ts#L1686-L1994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants