Skip to content

Add default ctor in ChangeList class #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twarit-waikar merged 2 commits into from
Feb 4, 2025
Merged

Add default ctor in ChangeList class #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
012c8f1
Add default ctor in ChangeList class
twarit-waikar Feb 4, 2025
d82d114
Add comment in main.cc about using resize() to trunc
twarit-waikar Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions p4-fusion/commands/change_list.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ struct ChangeList
int filesDownloaded;
State state;

ChangeList() = default; // Defaulted so that vector<ChangeList>::resize() can be used.
ChangeList(const std::string& number, const std::string& description, const std::string& user, const int64_t& timestamp);

ChangeList(const ChangeList& other) = delete;
Expand Down
1 change: 1 addition & 0 deletions p4-fusion/main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ int Main(int argc, char** argv)
// Truncate excess changes
if ((maxChanges > -1) && (changes.size() > maxChanges))
{
// We don't need to consider the case if this ever expands the vector.
changes.resize(maxChanges);
}
}
Expand Down
Loading