Upgrade libgit2 to v1.8.5.

[sstepashka]

Recently we face a crash with heap corruption and it seems was reported in CVE-2024-24577. The upgrade to the latest version fixes the issue for us.

Steps:

cd vendor
rm -rf libgit2
curl -L -O https://github.com/libgit2/libgit2/archive/refs/tags/v1.8.5.tar.gz
tar -xzf v1.8.5.tar.gz
mv libgit2-1.8.5 libgit2
rm v1.8.5.tar.gz
git add libgit2

[salesforce-cla]

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Dmitrii Kuragin <d***@A***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

[sstepashka]

I believe it also fixes #94 since zlib is a part of libgit2.

[sstepashka]

@twarit-waikar PTAL?

[twarit-waikar]

The decision to upgrade is probably good. I should really fix the CI builds at this point...

[twarit-waikar]

@sstepashka Could you rebase this branch? I sent some minor CI changes to make your build checks pass the next time they run after the rebase

[sstepashka]

@twarit-waikar It is done. We just hit the heap corruption crash, that's the main reason for the update. And it seems the heap corrupotion crash and the CVE are the same problem. Updating solved the problem completely.

[sstepashka]

@twarit-waikar Are we sure this does the right thing?

https://github.com/salesforce/p4-fusion/actions/runs/22627294521/workflow?pr=97#L14-L20

    - name: Cache vendor/
      uses: actions/cache@v3
      with:
        path: vendor/
        key: ${{ runner.OS }}-p4-fusion-vendor-cache-${{ github.ref }}
        restore-keys: |
          ${{ runner.OS }}-p4-fusion-vendor-cache-

[sstepashka]

@twarit-waikar friendly ping?