Bump Go builder image to 1.23, add docker-build target, minor fixes#289
Open
xavier-re wants to merge 1 commit intosalesforce:masterfrom
Open
Bump Go builder image to 1.23, add docker-build target, minor fixes#289xavier-re wants to merge 1 commit intosalesforce:masterfrom
xavier-re wants to merge 1 commit intosalesforce:masterfrom
Conversation
Restore multi-stage Docker build so Go compilation happens inside the container for better isolation and reproducibility. Bump builder image from golang:1.19 to golang:1.23 to address known CVEs. Add `docker-build` Makefile target that builds the Docker image directly from the repo root, bypassing goreleaser's limited build context. Update deprecated goreleaser `--rm-dist` flag to `--clean`. Fix missing error check after ClientConfig() in kubeclient.go and remove stray blank line in logging.go. Fixes salesforce#288
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Xavier Renaut <x***@g***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
xavier-re
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
docker-buildMakefile target for building the image directly from repo root--rm-distflag to--cleanClientConfig()inkubeclient.go(prevents nil-pointer panic)Which issue(s) this PR fixes:
Fixes #288
Special notes:
Existing
docker-snapshotanddockerMakefile targets are unchanged — they still use goreleaser. The newdocker-buildtarget is a standalone alternative.Tests:
make docker-buildbuilds successfullyPR Checklist: