Skip to content

test: add an assertion for SF_MDAPI_TEMP_DIR fix @W-19870602@ #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristiand391 merged 4 commits into from
Oct 21, 2025
Merged

test: add an assertion for SF_MDAPI_TEMP_DIR fix @W-19870602@ #1460

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
430c288
test: add an assertion for SF_MDAPI_TEMP_DIR fix
WillieRuemmele Oct 13, 2025
38239ed
Merge remote-tracking branch 'origin/main' into wr/fixTempDirDateInPath
cristiand391 Oct 21, 2025
7a42c05
chore: bump sdr
cristiand391 Oct 21, 2025
f5f5ac6
test: fix regex assertion
WillieRuemmele Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions test/commands/deploy/metadata.nut.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,26 @@
*/

import { fileURLToPath } from 'node:url';
import { join } from 'node:path';
import { readdir } from 'node:fs/promises';
import { SourceTestkit } from '@salesforce/source-testkit';
import { expect } from 'chai';

async function getAllFilePaths(dir: string): Promise<string[]> {
let filePaths: string[] = [];
const entries = await readdir(dir, { withFileTypes: true });

for (const entry of entries) {
const fullPath = join(dir, entry.name);
if (entry.isFile()) {
filePaths.push(fullPath);
} else if (entry.isDirectory()) {
// eslint-disable-next-line no-await-in-loop
filePaths = filePaths.concat(await getAllFilePaths(fullPath));
}
}
return filePaths;
}

describe('deploy metadata NUTs', () => {
let testkit: SourceTestkit;
Expand All @@ -31,9 +50,19 @@ describe('deploy metadata NUTs', () => {

describe('--metadata flag', () => {
it('should deploy ApexClass', async () => {
process.env.SF_MDAPI_TEMP_DIR = 'myTempDirectory';
await testkit.modifyLocalGlobs(['force-app/main/default/classes/*.cls'], '// comment');
await testkit.deploy({ args: '--metadata ApexClass' });
await testkit.expect.filesToBeDeployed(['force-app/main/default/classes/*']);

// no illegal file paths should be generated when using SF_MDAPI_TEMP_DIR
expect(
(await getAllFilePaths(join(testkit.projectDir, process.env.SF_MDAPI_TEMP_DIR))).every(
(path) => !/[<>:"/\\|?*]/.test(path)
)
).to.be.true;

delete process.env.SF_MDAPI_TEMP_DIR;
});

it('should deploy named ApexClass', async () => {
Expand Down
Loading