Conversation
@W-12558108@
…c-test into phale/repo-setup
|
using standard dreamhouse ❌ [fixed in QA Pr] ✅ setup test did what I expected ❌ ❓ I can't get the PASSTHROUGH args to work. ❌
|
mshanemc
left a comment
mshanemc
left a comment
There was a problem hiding this comment.
approved with non-blocking suggestions
| * | ||
| * The resulting argv array is then passed to the runJest method as arguments. | ||
| */ | ||
| const addArgs: string[] = []; |
There was a problem hiding this comment.
remove since all the intermediary mutating pushes are gone
| const addArgs: string[] = []; | |
| const addArgs: string[] = []; |
| addArgs.push(args.passthrough); | ||
| // remove the '--', '--json' and 'loglevel' flags from the this.argv array | ||
| const tArgv = this.argv.filter((arg) => !['--', '--json', 'loglevel'].includes(arg)); | ||
|
|
There was a problem hiding this comment.
why is json --json but loglevel isn't ?
Co-authored-by: Shane McLaughlin <m.shane.mclaughlin@gmail.com>
|
|
||
| const hasWatchFlag = tArgv.includes('--watch'); | ||
| const hasDebugFlag = tArgv.some(arg => /--debug|-d/.test(arg)); | ||
|
|
There was a problem hiding this comment.
false positive for --detectopenhandles. Regex might need start/end anchors?
https://jestjs.io/docs/cli#--detectopenhandles
5 participants
What does this PR do?
Adds wireit build tooling and bumps deps
What issues does this PR fix or reference?
@W-12558108@