Skip to content

Conversation

rNoz
Copy link
Contributor

@rNoz rNoz commented Jun 17, 2025

After this #185, now that we have a test detecting the current value returned by that function, let's modify functionality of exec:default(portexe), providing better errors and "" under wrong conditions.

4 new tests will show its behavior under different scenarios.

===> Verifying dependencies...
===> Analyzing applications...
===> Compiling erlexec
===> Performing EUnit tests...
....................
==> Test Concurrency: 900
......
Finished in 15.443 seconds
26 tests, 0 failures

Remaining bit:

  • I would like to refactor setup/teardown of tests (a private helper function to rename/backup priv dir).
  • I manually format these lines but let me know with further suggestions :)

Again, thanks for this library!

Updating PR showing how I am testing it from an Elixir release. Warning message is clarifying it:

image

@rNoz rNoz force-pushed the rnoz/better-errors branch 2 times, most recently from 5e37af2 to d659080 Compare June 17, 2025 10:46
@saleyn
Copy link
Owner

saleyn commented Jun 19, 2025

@rNoz this requires a rebase on the other merged PR

@rNoz rNoz force-pushed the rnoz/better-errors branch from d659080 to e339dc1 Compare June 19, 2025 07:20
@rNoz
Copy link
Contributor Author

rNoz commented Jun 19, 2025

@saleyn thanks! rebased :)

In a few days I could invest a few more time to refactor the setup sections, but test/code-wise is complete and fully checked. We can wait or I can provide the refactors as another PR (along with another minor proposal).

@rNoz rNoz marked this pull request as ready for review June 25, 2025 09:05
@rNoz
Copy link
Contributor Author

rNoz commented Jun 25, 2025

@saleyn ready, just refactored :)

@saleyn saleyn merged commit f73eb90 into saleyn:master Jun 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants