Skip to content

Swift 6 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Swift 6 #5

wants to merge 6 commits into from

Conversation

hishma
Copy link
Contributor

@hishma hishma commented Jun 24, 2024

This is a major refactoring that enables strict concurrency checking.

It introduces backward breaking changes that will require a major version bump.

The largest change is that the formatters can now only be configured upon initialization, so this settings become immutable.

Other changes include the adoption of the new Swift Testing framework. This requires Xcode 16.

hishma added 4 commits June 24, 2024 07:17
@hishma hishma requested a review from toddheasley June 24, 2024 14:57
@hishma hishma added this to the 2.0 milestone Jun 24, 2024
Copy link
Collaborator

@toddheasley toddheasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Test scheme doesn't run all the tests, see my note. Any reason to not bump everything to Swift 6, even though it's pre-release?

func testHorizontalUncertainty() {
var location = CLLocation(coordinate: .pointNemo)
XCTAssertNil(location.horizontalUncertainty)
struct CLLocationTests {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these nested test suites, the enclosing struct needs @Suite annotation if it doesn't (directly) contain any @Tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Son of a…

I was wondering why the ef those weren't running,
@hishma
Copy link
Contributor Author

hishma commented Jun 26, 2024

Any reason to not bump everything to Swift 6, even though it's pre-release?

Not really, I just wanted to try it one step at a time.

@hishma hishma requested a review from toddheasley June 26, 2024 14:57
@hishma
Copy link
Contributor Author

hishma commented Jun 26, 2024

It may be a while before GitHub actions supports macOS 15, so the tests won't build until then. Hopefully once the public betas are out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants