Skip to content

Leverage PHPStan conditional return types for more precise return-type declarations #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sammyjo20 merged 2 commits into from
May 2, 2025
Merged

Leverage PHPStan conditional return types for more precise return-type declarations #492

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6e6b7b
Leverage PHPStan conditional return types for more precise return-typ…
yankewei Apr 27, 2025
ef673f0
Merge branch 'v3' into yankewei/v3
Sammyjo20 May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Traits/OAuth2/AuthorizationCodeGrant.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ public function getAuthorizationUrl(array $scopes = [], ?string $state = null, s
* @template TRequest of \Saloon\Http\Request
*
* @param callable(TRequest): (void)|null $requestModifier
*
* @return ($returnResponse is true ? \Saloon\Http\Response : \Saloon\Contracts\OAuthAuthenticator)
*
* @throws \Saloon\Exceptions\InvalidStateException
*/
public function getAccessToken(string $code, ?string $state = null, ?string $expectedState = null, bool $returnResponse = false, ?callable $requestModifier = null): OAuthAuthenticator|Response
Expand Down Expand Up @@ -108,6 +111,8 @@ public function getAccessToken(string $code, ?string $state = null, ?string $exp
* @template TRequest of \Saloon\Http\Request
*
* @param callable(TRequest): (void)|null $requestModifier
*
* @return ($returnResponse is true ? \Saloon\Http\Response : \Saloon\Contracts\OAuthAuthenticator)
*/
public function refreshAccessToken(OAuthAuthenticator|string $refreshToken, bool $returnResponse = false, ?callable $requestModifier = null): OAuthAuthenticator|Response
{
Expand Down