Shrink DatabaseKeyIndex to 8 bytes to save memory
#1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #1045 will improve performance by 5.42%Comparing Summary
Benchmarks breakdown
|
ChayimFriedman2
force-pushed
the
shrink-dki
branch
2 times, most recently
from
6d82799 to
005814e
Compare
Via the observation that: - The `IngredientIndex` can be retrieved from the page, except for tracked fns - The generation is useless, except for interneds And since they don't overlap, we can store only what needed for each.
ChayimFriedman2
force-pushed
the
shrink-dki
branch
from
005814e to
35a1b50
Compare
Contributor
Author
|
GitHub actions out of storage... |
Contributor
|
Nice, there are some test failures (re-running fixed the temporary out-of-disk-space error) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via the observation that:
IngredientIndexcan be retrieved from the page, except for tracked fnsAnd since they don't overlap, we can store only what needed for each.
For rust-analyzer, this saves 55mb on itself and 200mb on a large codebase (omicron).